Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Refix for pyparsing compat.#21501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -15,7 +15,7 @@ | ||
from pyparsing import ( | ||
Combine, Empty, FollowedBy, Forward, Group, Literal, oneOf, OneOrMore, | ||
Optional, ParseBaseException, ParseFatalException, ParserElement, | ||
ParseResults, QuotedString, Regex, StringEnd, Suppress,White,ZeroOrMore) | ||
import matplotlib as mpl | ||
from . import _api, cbook | ||
@@ -2060,6 +2060,7 @@ def __init__(self): | ||
p.accent <<= Group( | ||
Suppress(p.bslash) | ||
+ oneOf([*self._accent_map, *self._wide_accents]) | ||
+ Suppress(Optional(White())) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. If the code is not working without this explicit whitespace-skipping, that is a pyparsing bug. Since you have made it Optional, then this won't break once the pyparsing bug is fixed. (You can also - or at leastshould be able to - use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Ok. Thereis a bug in pyparsing, but fixing it doesn't completely solve your problem. What is the purpose of
It looks like this is the only element in So:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Agreed that removing leaveWhitespace seems to work; looking at the git history it seems to be a historical artefact of the times when symbol and symbol_name were not split, and was used for symbol_name. | ||
- p.placeable | ||
) | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -2,7 +2,6 @@ | ||
certifi | ||
coverage | ||
pytest!=4.6.0,!=5.4.0 | ||
pytest-cov | ||
pytest-rerunfailures | ||