NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Also exclude pyparsing 3.0.0 in setup.py.#21446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 1 commit intomatplotlib:mainfromanntzer:p3

Oct 24, 2021

Merged

Also exclude pyparsing 3.0.0 in setup.py.#21446

jklymak merged 1 commit intomatplotlib:mainfromanntzer:p3

Oct 24, 2021

Conversation

Copy link

Contributor

PR Summary

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak approved these changes

Oct 24, 2021

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ooops!

Copy link

Member

timhoffm commentedOct 24, 2021

The other pins use <3 not !=3. Is this a bug in pyparsing or an API change we have to adapt to?

Copy link

Member

jklymak commentedOct 24, 2021

I did less than 3.0.0 pending investigation to get CI to work. I'm not sure what the permanent solution is.

Copy link

Member

dstansby commentedOct 24, 2021

Yeah, I think< is probably preferred here.

Also exclude pyparsing 3.0.0 in setup.py.

40f8049

Copy link

ContributorAuthor

anntzer commentedOct 24, 2021

< it is.

anntzer force-pushed thep3 branch froma4e0988 to40f8049Compare

October 24, 2021 13:19

timhoffm approved these changes

Oct 24, 2021

View reviewed changes

Copy link

Member

timhoffm commentedOct 24, 2021

Anybody can merge after CI pass.

jklymak merged commit4a23d21 intomatplotlib:main

Oct 24, 2021

anntzer deleted the p3 branch

October 24, 2021 16:51

Copy link

Member

timhoffm commentedOct 24, 2021

@meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request

Oct 24, 2021

Backport PRmatplotlib#21446: Also exclude pyparsing 3.0.0 in setup.py.

6d70c8b

meeseeksmachine mentioned this pull request

Oct 24, 2021

Backport PR #21446 on branch v3.5.x (Also exclude pyparsing 3.0.0 in setup.py.)#21452

Merged

timhoffm added a commit that referenced this pull request

Oct 24, 2021

Merge pull request#21452from meeseeksmachine/auto-backport-of-pr-21…

36162a4

…446-on-v3.5.xBackport PR#21446 on branch v3.5.x (Also exclude pyparsing 3.0.0 in setup.py.)

Copy link

mriedem commentedOct 25, 2021•
edited
Loading

Any idea when this might get released? I'd like to avoid having to do the same cap on pyparsing in our project (which pulls in matplotlib as a transitive dependency, we don't require pyparsing directly) if we can just get it this way.