Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Also exclude pyparsing 3.0.0 in setup.py.#21446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ooops!
The other pins use <3 not !=3. Is this a bug in pyparsing or an API change we have to adapt to? |
I did less than 3.0.0 pending investigation to get CI to work. I'm not sure what the permanent solution is. |
Yeah, I think |
|
Anybody can merge after CI pass. |
@meeseeksdev backport to v3.5.x |
…446-on-v3.5.xBackport PR#21446 on branch v3.5.x (Also exclude pyparsing 3.0.0 in setup.py.)
mriedem commentedOct 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Any idea when this might get released? I'd like to avoid having to do the same cap on pyparsing in our project (which pulls in matplotlib as a transitive dependency, we don't require pyparsing directly) if we can just get it this way. |
Hopefully this week, we have 1 blocking issue left for 3.5 |
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).