Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: re-instate ability to have position in axes#21443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromjklymak:fix-position-axes
Nov 5, 2021

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedOct 23, 2021
edited
Loading

PR Summary

Closes#21441

import matplotlib.pyplot as pltfig = plt.figure()pos1 = [0.1, 0.1, 0.3, 0.8]pos2 = [0.5, 0.1, 0.4, 0.6]ax1 = plt.axes(position = pos1)ax1.plot([0,1], [0, 1], color = 'r', linewidth = 3)ax2 = plt.axes(position = pos2)ax2.plot([1, 0], [0, 1], color = 'b', linestyle = '--')

is documented to work, but position is silently ignored.position is just redundant withrect, so go ahead and check for position if rect is None.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswell
Copy link
Member

Do we want to sneak this in for 3.5.0?

@jklymakjklymak marked this pull request as ready for reviewOctober 29, 2021 18:39
@jklymak
Copy link
MemberAuthor

I think that would be fine, OTOH, its a bit of an edge case and not urgent, I don't think

@QuLogicQuLogic merged commit3d7dea5 intomatplotlib:mainNov 5, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 5, 2021
jklymak pushed a commit that referenced this pull requestNov 7, 2021
…21543)Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogicQuLogic modified the milestones:v3.5.1,v3.5.0Nov 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

[Bug]: axes(position = [...]) behavior
3 participants
@jklymak@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp