Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Log pixel coordinates in event_handling coords_demo example on terminal/console#21389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromjatin837:unused-pxl-coord
Oct 20, 2021

Conversation

jatin837
Copy link
Contributor

@jatin837jatin837 commentedOct 20, 2021
edited
Loading

PR Summary

coords_demo.py example has unused variables for pixel values. This PR attempts to improve this by logging pixel value, alongside axis data on the terminal/console where this specific example is running

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@story645
Copy link
Member

Hi, thanks for the PR! Please edit your post to add a short summary of why you're making these changes.

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is actually helpful. Thanks!

@jklymakjklymak added this to thev3.6.0 milestoneOct 20, 2021
@jatin837
Copy link
ContributorAuthor

Hi, thanks for the PR! Please edit your post to add a short summary of why you're making these changes.

thanks@story645 for help. i have added the summary. hope it explains role of my PR.

story645 reacted with thumbs up emoji

@dstansbydstansby merged commitf6e0ee4 intomatplotlib:masterOct 20, 2021
@story645
Copy link
Member

Congrats on the PR, hope to see you again! 🎉

@jatin837jatin837 deleted the unused-pxl-coord branchOctober 20, 2021 11:56
@jatin837
Copy link
ContributorAuthor

Congrats on the PR, hope to see you again! 🎉

Yeah definitely@story645 😊

tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Log pixel coordinates in event_handling coords_demo example on terminal/console
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@jklymakjklymakjklymak approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

4 participants
@jatin837@story645@jklymak@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp