Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add GHA testing whether files were added and deleted in the same PR.#21359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
940ffb9 tocdc9e73CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Optional: Can we make the message stand out more? It's a bit burried between the other output:
Maybe add------------ lines above and below? Or do you have a better idea?
I removed the other output. |
You can print out a special message which executes aworkflow command, creating an annotation. I'm not sure how it looks if the annotation is on a file that is subsequently deleted. |
anntzer commentedOct 14, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm not sure I really want to try (and loop over lines in bash, which I never remember how to do :-)), but you should feel free to do so :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks helpful!
@anntzer this is ready. Please remove the test commits. |
Done. |
@meeseeksdev backport to v3.5.x |
…d and deleted in the same PR.
…359-on-v3.5.xBackport PR#21359 on branch v3.5.x (Add GHA testing whether files were added and deleted in the same PR.)
Add GHA testing whether files were added and deleted in the same PR.
PR Summary
Currently has two extra commits that test the functionality and should fail the workflow. Will remove these commits once we know this works.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).