Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Added linear scaling test to Hexbin marginals#21339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems good, but snapping should be default and you will need to change the image.
Have changed snapping to default and updated the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, one more request - we try and reduce the number of tests with fonts in them (when we un-pin font tools it changes a bunch of images). I know the other test has fonts, but can this one not have them? i.e.remove_text=True in the test parameters?
Uh oh!
There was an error while loading.Please reload this page.
If anyone merges this, please squash merge (or@j-bowhay you can rebase and squash the commits, and force push back here (make a back up branch first if you aren't used to doing this!)). This is particularly important to prevent the stray image from being in the repo. Thanks for your patience with the process!. |
timhoffm left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lets move to draft until we sort out.@j-bowhay please ping us if the issue with hex bin does not get resolved soon. |
This PR is affected by a re-writing of our history to remove a large number of accidentally committed filessee discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote updategit checkout maingit merge --ff-only upstream/maingit checkout YOUR_BRANCHgit rebase --onto=main upstream/old_master# git rebase -i main # if you prefergit push --force-with-lease# assuming you are tracking your branch If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This definitely needs updating or adopting in it's current state - see the above comment!
Hey@j-bowhay, are you still working in this PR? Because it is been inactive for a long time. Hope I am not disturbing you. |
Hi@LucasRicci this was blocked on#21349 by@timhoffm so I have not made the requested changes yet. I see there has been no progress on this issue yet. I am happy to finish the pr once the issue is fixed or if it is decided to add these test with the bug present and then update later. |
@j-bowhay Oh I see, thanks |
Not blocked by#21349 anymore because, that turned out to be not a bug.
@j-bowhay thanks for the ping, and thanks for the PR! |
PR Summary
Added test for hexbin marginals that uses a linear scale.Closes#21165
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).