Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: Bump to the sphinx-gallery release#21291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Also update |
Now that it's out, we don't need to depend on a random commit.
ce33c2e to0fca630CompareI always forget about that... |
| @@ -32,13 +32,10 @@ dependencies: | |||
| - scipy | |||
| - sphinx>=1.8.1,!=2.0.0 | |||
| - sphinx-copybutton | |||
| - sphinx-gallery>=0.10 | |||
| - pip | |||
| - pip: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could put a cross-reference in the conda environment file so that only one location would be the source of truth.
| -pip: | |
| -pip: | |
| --r file:requirements/doc/doc-requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I‘m somewhat sceptical on mixing conda and pip packages more than necessary. That could cause unnecessary dependency conflicts. If you think we need something better than manual syncing, please open an issue to discuss options.
| @@ -32,13 +32,10 @@ dependencies: | |||
| - scipy | |||
| - sphinx>=1.8.1,!=2.0.0 | |||
| - sphinx-copybutton | |||
| - sphinx-gallery>=0.10 | |||
| - pip | |||
| - pip: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I‘m somewhat sceptical on mixing conda and pip packages more than necessary. That could cause unnecessary dependency conflicts. If you think we need something better than manual syncing, please open an issue to discuss options.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free tosuggest an improvement. |
…3.5.xBackport PR#21291 on branch v3.5.x (DOC: Bump to the sphinx-gallery release)
DOC: Bump to the sphinx-gallery release
DOC: Bump to the sphinx-gallery release
PR Summary
Now that it's out, we don't need to depend on a random commit.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).