Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify _init_legend_box.#21289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:ilb
Oct 15, 2021
Merged

Simplify _init_legend_box.#21289

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:ilb
Oct 15, 2021

Conversation

anntzer
Copy link
Contributor

Reword some comments.
Inlinelabel_prop to its only use site (previously quite far away from
the definition).
Renamelab tolabel, and some unCamelCasing.
Replace the manual splitting-into-columns computation by a single call
to np.array_split followed by filtering away empty columns.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Reword some comments.Inline `label_prop` to its only use site (previously quite far away fromthe definition).Rename `lab` to `label`, and some unCamelCasing.Replace the manual splitting-into-columns computation by a single callto np.array_split followed by filtering away empty columns.
@QuLogicQuLogic added this to thev3.6.0 milestoneOct 15, 2021
@QuLogicQuLogic merged commit5f4a8ad intomatplotlib:masterOct 15, 2021
@anntzeranntzer deleted the ilb branchOctober 15, 2021 07:10
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp