Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use correct confidence interval#21216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 2 commits intomatplotlib:masterfromliamtoney:patch-1
Sep 29, 2021
Merged

Use correct confidence interval#21216

tacaswell merged 2 commits intomatplotlib:masterfromliamtoney:patch-1
Sep 29, 2021

Conversation

liamtoney
Copy link
Contributor

PR Summary

Correct the confidence interval corresponding to 3 standard deviations in 2-D. The value is taken fromthis paper — see Eq. 19.

The paper includes atable which gives confidence levels for different numbers of standard deviations (their "Magnification factor"):

Screen Shot 2021-09-28 at 4 41 56 PM

I think, with this robust reference, we could improve upon#19074. Thanks for the support@CarstenSchelp.

PR Checklist

  • [N/A] Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswelltacaswell merged commitb78b47a intomatplotlib:masterSep 29, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 29, 2021
@tacaswell
Copy link
Member

Thank you@liamtoney ! Congratulations on your first Matplotlib PR 🎉 hopefully we will hear from you again.

liamtoney reacted with thumbs up emoji

timhoffm added a commit that referenced this pull requestSep 29, 2021
…216-on-v3.5.xBackport PR#21216 on branch v3.5.x (Use correct confidence interval)
@liamtoneyliamtoney deleted the patch-1 branchSeptember 29, 2021 20:02
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestOct 12, 2021
DOC: Use correct confidence interval in example prose
tacaswell added a commit that referenced this pull requestOct 20, 2021
DOC: Use correct confidence interval in example prose
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

2 participants
@liamtoney@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp