Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate mlab.stride_windows.#21190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The functionality is directly provided by numpy>=1.20 (it will be awhile before we can rely on that version of numpy, but we can stilldeprecate stride_windows as public API in the meantime, as we don't wantto encourage users to rely on mlab for that).
Deprecate mlab.stride_windows.
Deprecate mlab.stride_windows.
QuLogic commentedAug 22, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
So the NumPy version actuallyOOMs in
while patching to the original still passes the test. That being said, I'm hoping I can drop 32-bit support soon, and not have to worry about this, but maybe this new method is using more memory than it should? |
The functionality is directly provided by numpy>=1.20 (it will be a
while before we can rely on that version of numpy, but we can still
deprecate stride_windows as public API in the meantime, as we don't want
to encourage users to rely on mlab for that).
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).