Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Deprecate mlab.stride_windows.#21190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromanntzer:sw
Sep 27, 2021
Merged

Conversation

anntzer
Copy link
Contributor

The functionality is directly provided by numpy>=1.20 (it will be a
while before we can rely on that version of numpy, but we can still
deprecate stride_windows as public API in the meantime, as we don't want
to encourage users to rely on mlab for that).

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

The functionality is directly provided by numpy>=1.20 (it will be awhile before we can rely on that version of numpy, but we can stilldeprecate stride_windows as public API in the meantime, as we don't wantto encourage users to rely on mlab for that).
@anntzeranntzer added this to thev3.6.0 milestoneSep 27, 2021
@dstansbydstansby merged commit6c2f514 intomatplotlib:masterSep 27, 2021
@anntzeranntzer deleted the sw branchSeptember 27, 2021 18:59
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestOct 12, 2021
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Deprecate mlab.stride_windows.
@QuLogic
Copy link
Member

QuLogic commentedAug 22, 2022
edited
Loading

So the NumPy version actuallyOOMs intest_psd_csd on 32-bit x86 with

E       ValueError: array is too big; `arr.size * arr.dtype.itemsize` is larger than the maximum possible size.

while patching to the original still passes the test.

That being said, I'm hoping I can drop 32-bit support soon, and not have to worry about this, but maybe this new method is using more memory than it should?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@QuLogic@story645@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp