Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Added option for an offset for MultipleLocator#21168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Added option for an offset for MultipleLocator#21168
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Fixesmatplotlib#20516PGF's `random steps` decoration seems to be the most similar,but does not exactly match the behaviour described in matplotlib's docs.Therefore I repurposed the `randomness` argument as a seed to givecontrol on how the line looks afterwards.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Switch documented deprecations in mathtext by `__getattr__` deprecations
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
…_outputAPI: rename draw_no_output to draw_without_rendering
Make warning for no-handles legend more explicit.
Remove unused HostAxes._get_legend_handles.
Redirect to new 3rd party packages page
legend_handler_map cleanups.
Clean up some Event class docs.
- parse() already normalizes prop=None to prop=FontProperties().- We don't need to explicitly attach a canvas to a plain Figure() before calling savefig() anymore; FigureCanvasBase is always attached and handles the dispatching to the correct concrete canvas class.
According to the docs, this function was added in GTK 2.2, so probablywas only needed when we supported GTK2.It also no longer exists in GTK4.
Since these examples don't need to support the very oldest GTK3, I tookthe opportunity to rewrite them using the recommended Application-styledmodel.
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.... and small local cleanups.
- Use finite differences to estimate derivative rather than splines (which are conceptually much more complicated).- Include a "constant error" case, which shows that the band does have constant width in that case.- Force the axes aspect to 1 (so that constant width actually appears constant).- Use np.full() to set up the codes array.
The pixel-sized marker previously use (",") was so small that it lookedmore like a rendering artefact than an actual data point.DOC: Increase marker size in double_pendulum example.
DOC: Improve curve_error_band example.
DOC: Docstring cleanups around DATA_PARAMETER_PLACEHOLDER.
MNT: Simplify argument parsing in stem().
This declutters the code.
There is no need to generate a regular grid and statistically choosepoints from that. Instead, we can immediately choose random points.
Rename `**kw` to `**kwargs`.
Add conda environment.yml for developers
Co-authored-by: hannah <story645@gmail.com>
More (minor) plot types gallery fixes.
Fix `hexbin` marginals and log scaling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
I moved to draft. Let us know if you still cannot build locally. There are quite a few of us using apple and I don't recall any (recent) issues building. Though there was something about clang versus cpp at some point, the solution to which you may be able to find in old issues. |
Will try again when I have time (may be several weeks though) …On Tue, Oct 12, 2021 at 5:57 AM Jody Klymak ***@***.***> wrote: I moved to draft. Let us know if you still cannot build locally. There are quite a few of us using apple and I don't recall any (recent) issues building. Though there was something about clang versus cpp at some point, the solution to which you may be able to find in old issues. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZCG2FKAFIYONX6UM6D65LUGQWFLANCNFSM5EWMJMLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. |
This PR is affected by a re-writing of our history to remove a large number of accidentally committed filessee discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote updategit checkout maingit merge --ff-only upstream/maingit checkout YOUR_BRANCHgit rebase --onto=main upstream/old_master# git rebase -i main # if you prefergit push --force-with-lease# assuming you are tracking your branch If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
Thanks@tacaswell@jklymak, The PR only changes three lines of code (should take 30 seconds for someone who already has a dev install of matplotlib). I can try rebasing, but it will take me a lot longer than 30 seconds to figure everything out. You can see the three simple changes here:ba6aeff Jonathan |
This seems like a useful thing to have, so I have picked it up in#25542. I think we can close this one now. Thank you for your work and for providing clear directions to the relevant commit@jondoesntgit! |
PR Summary
Allows for an optional kwarg
offsetto be passed to MultipleLocator. For example, allows ticks to be placed at (.5, 1.5, 2.5, 3.5) withMultipleLocator(base=1, offset=.5).PR Checklist
I cannot get matplotlib to build locally.
Once I can build, I can finish the other check marks in your checklist:
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).Other questions: