Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.#21141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:cqd
Sep 22, 2021

Conversation

@anntzer
Copy link
Contributor

The docstring must be set (which we do using docstring.dedent_interpd)
before the decoration with _preprocess_data().

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree that this is the pattern we use most other places...

The docstring must be set (which we do using docstring.dedent_interpd)before the decoration with _preprocess_data().While we're at it, replace kw by kwargs in quiver/barbs.
@anntzer
Copy link
ContributorAuthor

While I was at it, I also replacedkw bykwargs in quiver and barbs (doing so in a separate PR would have resulted in a merge conflict).

jklymak and timhoffm reacted with thumbs up emoji

@timhoffmtimhoffm added this to thev3.5.0 milestoneSep 22, 2021
@timhoffmtimhoffm merged commit1daed58 intomatplotlib:masterSep 22, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 22, 2021
@anntzeranntzer deleted the cqd branchSeptember 22, 2021 11:53
jklymak added a commit that referenced this pull requestSep 22, 2021
…141-on-v3.5.xBackport PR#21141 on branch v3.5.x (Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestOct 12, 2021
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Fix DATA_PARAMETER_PLACEHOLDER interpolation for quiver&contour{,f}.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer@jklymak@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp