Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix polar() regression on second call failure#21131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 2 commits intomatplotlib:masterfrombeckja:polar-fix
Sep 20, 2021
Merged

Fix polar() regression on second call failure#21131

jklymak merged 2 commits intomatplotlib:masterfrombeckja:polar-fix
Sep 20, 2021

Conversation

beckja
Copy link
Contributor

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@beckja
Copy link
ContributorAuthor

beckja commentedSep 19, 2021•
edited
Loading

This is a fix for issue#21113

@tacaswell
Copy link
Member

@beckja Do you feel up to adding a test for this?

@tacaswelltacaswell added this to thev3.4.4 milestoneSep 19, 2021
@tacaswell
Copy link
Member

Thanks@beckja ! I hope you do not mind, I took the liberty of pushing a slight modification to your test to use unpacking syntax (to make sure that only one thing is returned and to make the rest of the rest read a bit better).

Given that I pushed a commit to this PR I probably should not merge it.

@tacaswelltacaswell added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelSep 19, 2021
@beckja
Copy link
ContributorAuthor

@tacaswell appreciate the clean-up. This is my first pull request on any open source project, so grateful for the help.

@tacaswell
Copy link
Member

@beckja You identified a problem, proposed a fix, added a test, and look on track to get merged with only very minor revisions, so you are doing pretty good for your first PR!

@tacaswell
Copy link
Member

Congratulation@beckja on your first Matplotlib PR 🎉 !

Hopefully we will hear from you again.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestOct 12, 2021
Fix polar() regression on second call failure
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Fix polar() regression on second call failure
@QuLogicQuLogic modified the milestones:v3.4.4,v3.5.0Nov 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

5 participants
@beckja@tacaswell@jklymak@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp