Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix typo in template of current dev-docs#21062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

deep-jkl
Copy link
Contributor

PR Summary

I was recently working on some documentation and the new template took my attention, it looks great, good work. I found an typo in the main navigation barTutoraials ->Tutorials. Despite the fact that this is a single character PR I believe it has major impact and this will ease the process. I have not done any proof reading of the new documentation.

PR Checklist

  • [ N/A ] Has pytest style unit tests (andpytest passes).
  • [ N/A ] IsFlake 8 compliant (runflake8 on changed files to check).
  • [ N/A ] New features are documented, with examples if plot related.
  • [ ] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [ N/A ] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [ N/A ] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A ] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.4.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 d27fba34e8b99bc2ebc48c502530d8376a1b19ce
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #21062: Fix typo in template of current dev-docs'
  1. Push to a named branch :
git push YOURFORK v3.4.x:auto-backport-of-pr-21062-on-v3.4.x
  1. Create a PR against branch v3.4.x, I would have named this PR:

"Backport PR#21062 on branch v3.4.x (Fix typo in template of current dev-docs)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to removeStill Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free tosuggest an improvement.

@dstansbydstansby modified the milestones:v3.4.4,v3.5.0Sep 13, 2021
dstansby added a commit that referenced this pull requestSep 13, 2021
…062-on-v3.5.xBackport PR#21062 on branch v3.5.x (Fix typo in template of current dev-docs)
@tacaswell
Copy link
Member

Thank you@deep-jkl !

tacaswell pushed a commit that referenced this pull requestOct 20, 2021
@deep-jkldeep-jkl deleted the typo-in-new-doc-template branchApril 13, 2022 18:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

4 participants
@deep-jkl@tacaswell@story645@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp