Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate support for no-args MarkerStyle().#21056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Maybe remove the weird docstring sentence:
|
Reworded. Unfortunately the situation is still slightly confusing (see new wording). Actually deprecating support for |
As noted in the module docstring, there is a confusion between using ageneric default MarkerStyle (empty) and the artist-specific one (e.g.scatter plots use `rcParams["scatter.marker"]`). Fortunately, directconstruction of MarkerStyles (especially of empty ones) is hardly everneeded, so we can just make the parameter required.
Deprecate support for no-args MarkerStyle().
As noted in the module docstring, there is a confusion between using a
generic default MarkerStyle (empty) and the artist-specific one (e.g.
scatter plots use
rcParams["scatter.marker"]). Fortunately, directconstruction of MarkerStyles (especially of empty ones) is hardly ever
needed, so we can just make the parameter required.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).