Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Deprecate many single-use rc validators.#21054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's defer this to after the 3.5 release. I intend to start a general discussion on configuration handling for 3.6, an this deprecation may or may not match with its result.
I'll block to prevent accidential merging.
Sure, no worries. |
This PR is affected by a re-writing of our history to remove a large number of accidentally committed filessee discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote updategit checkout maingit merge --ff-only upstream/maingit checkout YOUR_BRANCHgit rebase --onto=main upstream/old_master# git rebase -i main # if you prefergit push --force-with-lease# assuming you are tracking your branch If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
They can all easily be defined inline at the place of use.
@timhoffm Do you still want to block this, even though that there hasn't been major reworking of rcparams since your last comment? (I'm totally OK if you do, in which case we should probably just close this.) |
I would still put this on hold. The first step in rcParams redesign is#25617. More will come after that. |
Let's just close this then. |
Note:#26088 now uses the validators as is. But we may change that later. |
They can all easily be defined inline at the place of use.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).