Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixhexbin marginals and log scaling#21039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 2 commits intomatplotlib:masterfromdstansby:hexbin-marginal
Sep 24, 2021

Conversation

dstansby
Copy link
Member

@dstansbydstansby commentedSep 10, 2021•
edited
Loading

PR Summary

This cleans up and fixes hexbin marginals. In particular:

  • Previously the marginal bins were displaced 1 too far to the right/up (see below)
  • Fixed marginals on log scales (see test image)

Also don't add 1 to log-scaled bins (originally in#21038).

Current master:
hexbin_broken

With this PR:
hexbin_fixed

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@dstansbydstansby changed the titleHexbin marginalHexbin fixesSep 10, 2021
@dstansbydstansby changed the titleHexbin fixesFixhexbin marginals and log scalingSep 12, 2021
@@ -781,7 +781,8 @@ def test_hexbin_log():
y = np.power(2, y * 0.5)

fig, ax = plt.subplots()
h = ax.hexbin(x, y, yscale='log', bins='log')
h = ax.hexbin(x, y, yscale='log', bins='log',
marginals=True, reduce_C_function=np.sum)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks like there is no linear scale marginals=True? Can we add that test?

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this should be in 3.5 so lets merge. My request for a test can be dealt with later...

@jklymakjklymak merged commit7c2a3c4 intomatplotlib:masterSep 24, 2021
@jklymakjklymak added this to thev3.5.0 milestoneSep 24, 2021
@jklymak
Copy link
Member

@meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 24, 2021
@dstansbydstansby deleted the hexbin-marginal branchSeptember 24, 2021 09:30
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestOct 12, 2021
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Fix `hexbin` marginals and log scaling
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

4 participants
@dstansby@jklymak@anntzer@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp