NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Don't add 1 to all hexbin data when using log norm#21038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

dstansby wants to merge1 commit intomatplotlib:masterfromdstansby:hexbin-log

Closed

Don't add 1 to all hexbin data when using log norm#21038

dstansby wants to merge1 commit intomatplotlib:masterfromdstansby:hexbin-log

Conversation

Copy link

Member

dstansby commentedSep 10, 2021

PR Summary

This seems very wrong - it means that every bin that doesn't actually have a data point turns up with a value of 1, and all other bins have a value of 1 added to them. We handle the case where the bin value = 0 and a log scale fine by just not showing the bin.

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

dstansby force-pushed thehexbin-log branch fromc8690fd to2034ccfCompare

September 10, 2021 09:06

Copy link

Member

jklymak commentedSep 10, 2021

What is the git blame for that? It'd be interesting to see the reasoning.

Copy link

Contributor

anntzer commentedSep 10, 2021

This came in in5f8a88a back in 2010, and I guess logzero handling was more iffy back then.
I agree that the current behavior is undesirable.
Some tests need to be updated, though.

Copy link

MemberAuthor

dstansby commentedSep 10, 2021

It goes all the way back to 2010:5f8a88a. I'm not sure what the motivation for it was, but perhaps handling zero values on a log norm didn't work as well back then?