Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Don't subslice lines if non-standard transform#21017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7ff497c to7c3147bCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A test would be nice, but I won't insist on it (I assume that you verified locally that it works :-))
No I'll add a test. Just was interrupted. |
e1ca3e7 to391cb76CompareNew commit adds a test that fails on master with all the data sliced out, and is fine with this PR. |
391cb76 toeba5cdcCompare…017-on-v3.5.xBackport PR#21017 on branch v3.5.x (FIX: Don't subslice lines if non-standard transform)
…017-on-v3.4.xBackport PR#21017 on branch v3.4.x (FIX: Don't subslice lines if non-standard transform)
FIX: Don't subslice lines if non-standard transform
PR Summary
Line2Dobjects are "sub sliced" if they are well-ordered, and their view window is smaller than the actual data extents. However, if someone applies a transform, in particular a lateral translation, then the data all ends up out of view. This adds a check to only apply the subslice algorithm if the transform isax.transData.Closes#21008
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).