Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Docstring cleanups.#20973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:masterfromanntzer:d401
Sep 2, 2021
Merged

Docstring cleanups.#20973

story645 merged 1 commit intomatplotlib:masterfromanntzer:d401
Sep 2, 2021

Conversation

anntzer
Copy link
Contributor

Mostly D401 (imperative mood) fixes, and a few other things.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Mostly D401 (imperative mood) fixes, and a few other things.
Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it's better even if my comments are ignored, I'm just confused

"""
The artist class that will be returned for SimpleArrow style.
"""
"""The artist class that will be returned for SimpleArrow style."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
"""The artistclass that will be returned forSimpleArrow style."""
"""The artistreturned when arrow style isSimpleArrow"""

"""
The artist class that will be returned for SimpleArrow style.
"""
"""The artist class that will be returned for SimpleArrow style."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What triggers this versus returning the SimpleArrow above?

@anntzer
Copy link
ContributorAuthor

Probably the whole axisline_style needs rewording, but let's not do that here.

@story645story645 merged commit039c94a intomatplotlib:masterSep 2, 2021
@anntzeranntzer deleted the d401 branchSeptember 2, 2021 11:39
@QuLogicQuLogic modified the milestones:v3.6.0,v3.5.0Sep 2, 2021
@QuLogic
Copy link
Member

@meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 2, 2021
QuLogic added a commit that referenced this pull requestSep 2, 2021
…973-on-v3.5.xBackport PR#20973 on branch v3.5.x (Docstring cleanups.)
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@story645

[8]ページ先頭

©2009-2025 Movatter.jp