Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Addition of numticks=N in LogLocator#20950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

manushree635
Copy link

@manushree635manushree635 commentedAug 31, 2021
edited
Loading

Addition of numticks=N in LogLocator in def _autolev(self, N):

PR Summary

"closes#19856"
Contour plots don't interact nicely with matplotlib.colors.LogNorm. Level=N doesn't work with LogNorm.
Added numticks=N in LogLocator in def _autolev(self, N):

PR Checklist

  • [ N/A] Has pytest style unit tests (andpytest passes).
  • [N/A] IsFlake 8 compliant (runflake8 on changed files to check).
  • [ N/A] New features are documented, with examples if plot related.
  • [ N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A ] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@jklymak
Copy link
Member

jklymak commentedAug 31, 2021
edited
Loading

@manushree635 Thanks a lot for the PR. Can you tidy up a bit and add a descriptive title and link the issue in the description instead of the title? If you say "closes#19856" it will automatically close.

Without looking at the original issue, I suspect you will want to add a test so that this doesn't break in the future.

@manushree635
Copy link
Author

@manushree635 Thanks a lot for the PR. Can you tidy up a bit and add a descriptive title and link the issue in the description instead of the title? If you say "closes#19856" it will automatically close.

Without looking at the original issue, I suspect you will want to add a test so that this doesn't break in the future.

done

@jklymakjklymak changed the titleManushree635 issue#19856Addition of numticks=N in LogLocatorAug 31, 2021
@jklymak
Copy link
Member

Thanks - this needs to pass the current test suite and preferably would have a new test.

@tacaswell
Copy link
Member

This PR is affected by a re-writing of our history to remove a large number of accidentally committed filessee discourse for details.

To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote"upstream"

git remote updategit checkout maingit merge --ff-only upstream/maingit checkout YOUR_BRANCHgit rebase --onto=main upstream/old_master# git rebase -i main # if you prefergit push --force-with-lease# assuming you are tracking your branch

If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you.

Thank you for your contributions to Matplotlib and sorry for the inconvenience.

@melissawm
Copy link
Member

Hi@manushree635 - are you interested in continuing this work? Please let us know if you need help moving forward. Cheers!

@dstansby
Copy link
Member

Given this is very old with no response, and is made obsolete by#27576, I'm going to close. Thanks for opening!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees
No one assigned
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Contours with LogNorm
7 participants
@manushree635@jklymak@tacaswell@melissawm@dstansby@QuLogic@rcomer

[8]ページ先頭

©2009-2025 Movatter.jp