Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Doc] colors.to_hex input & output#20913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 4 commits intomatplotlib:masterfromstory645:story645-to_hex
Sep 13, 2021

Conversation

story645
Copy link
Member

@story645story645 commentedAug 26, 2021
edited
Loading

added numpydoc style documentation of parameters to the colors.to_hex function


Parameters
----------
c : Matplotlib color or ``np.ma.masked``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just "color" (we say "color" in a bunch of doc descriptions to mean "matplotlib color"; this is not different).

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was super confused by what is color - RGBA, named, all of the above? (should color maybe cross link tohttps://matplotlib.org/devdocs/tutorials/colors/colors.html?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps, but that should probably be another discussion, similar to the joinstyle/capstyle one.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Like:rc:`some.param`, we should have a:concept:`color` directive (or similar) to make such links easier. But until then an explicit link is ok as well.

story645 reacted with thumbs up emoji
story645and others added2 commitsAugust 26, 2021 23:06
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
``#rrggbbaa`` otherwise.
Parameters
----------
c : :doc:`color </tutorials/colors/colors>` or `np.ma.masked`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
c : :doc:`color </tutorials/colors/colors>`or`np.ma.masked`
c : :doc:`color </tutorials/colors/colors>`or`numpy.ma.masked`

Sorry, need the original name to make the link working.

@timhoffmtimhoffm added this to thev3.5.0 milestoneSep 13, 2021
@timhoffmtimhoffm merged commit20170d7 intomatplotlib:masterSep 13, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 13, 2021
@story645story645 deleted the story645-to_hex branchSeptember 13, 2021 16:41
dstansby added a commit that referenced this pull requestSep 13, 2021
…913-on-v3.5.xBackport PR#20913 on branch v3.5.x ([Doc] colors.to_hex input & output)
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
ericpre pushed a commit to ericpre/matplotlib that referenced this pull requestOct 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer left review comments

@dstansbydstansbydstansby left review comments

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

4 participants
@story645@anntzer@timhoffm@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp