Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Move sigint tests into subprocesses#20907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Strange, it fails when the entire test suite is run, but not when running only the one test (or even just the one file). |
Ah, it's probably because |
6eab1f1 tof2740fdCompare112668e toa40759cCompare20c764d toc2a5cb2CompareThis prevents them accidentally breaking the test runner itself,depending on platform.
c2a5cb2 to9d13e7dCompare| qt_core.QTimer.singleShot(100, fire_sigint) | ||
| def custom_signal_handler(signum, frame): | ||
| timer.start() | ||
| signal.signal(signal.SIGUSR1, custom_signal_handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is a whole bunch of code here that is not being run. Is that on purpose/it will be run at a later date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Everything in*_impl functions are run in a subprocess which coverage doesn't see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+/- explaining why the BlockingIOError can be ignored.
…907-on-v3.5.xBackport PR#20907 on branch v3.5.x (Move sigint tests into subprocesses)
Move sigint tests into subprocesses
Move sigint tests into subprocesses
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This prevents them accidentally breaking the test runner itself, depending on platform. Also, enable Qt tests on AppVeyor. A followup to#20883.
I haven't convertedtest_fig_sigint_overrideyet, as I want to see if this works on Windows.test_fig_sigint_overridedoesn't actually fire any signals, but I modified it to ensure it doesn't leave broken global state.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).