Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use release-branch version scheme#20903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ericpre
Copy link
Member

PR Summary

At the time of writing (latest master just installed), the installed and runtime version (from a git repository) are:

>>>importimportlib_metadata>>>importlib_metadata.version('matplotlib')'3.5.0.dev1801+g298e92f6bf'

and

>>>importmatplotlib>>>matplotlib.__version__'3.4.2.post1801+g298e92f6bf'

With this PR, the runtime version is:

>>>importmatplotlib>>>matplotlib.__version__'3.5.0.dev1802+g3593a0c333'

Relevant previous PR on this topic:#18869,#20369,

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Copy link
Member

I think I was probably waiting for a release with that in before changing it; we should probably ping them about that.

@ericpre
Copy link
MemberAuthor

I think I was probably waiting for a release with that in before changing it; we should probably ping them about that.

Am I understanding correctly that with "ping them" you mean thesetuptools_scm developers and the version we get currently is incorrect, because ofpypa/setuptools-scm#571: it should be '3.6.0.dev1802+g3593a0c333' instead of '3.5.0.dev1802+g3593a0c333'
If so, it looks to me that this is a different issue, because this PR is about ensuring the installed version and runtime version follows the same scheme and are consistents!

In any case, it is worth pinging them! ;)

Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is simply making__init__.py matchsetup.py.

@ericpre
Copy link
MemberAuthor

This is simply making__init__.py matchsetup.py.

Yes, this is correct.

If one want to test against some feature which are in themaster and use the runtime version to know if the feature is available, then the current runtime version is not useful because unlike the install version defined insetup.py, the runtime version says:

>>>importmatplotlib>>>matplotlib.__version__'3.4.2.post1954+g20170d7558.d20210913'

As far I understand, this version corresponds to a bug-fix branch and I would expect something along the line of3.5.0.devXX and3.6.0.devXX after3.5.0 is tagged.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

They now have a release out with this included.

@QuLogicQuLogic added this to thev3.5.0 milestoneSep 13, 2021
@tacaswelltacaswell merged commitec3966b intomatplotlib:masterSep 16, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 16, 2021
timhoffm added a commit that referenced this pull requestSep 16, 2021
…903-on-v3.5.xBackport PR#20903 on branch v3.5.x (Use release-branch version scheme )
tacaswell added a commit that referenced this pull requestOct 20, 2021
ericpre pushed a commit to ericpre/matplotlib that referenced this pull requestOct 20, 2021
…_git_repoBLD: Use release-branch version scheme
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

4 participants
@ericpre@QuLogic@anntzer@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp