Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make pywin32 optional in Ctrl+C Qt test.#20883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromQuLogic:qt-interrupt-cleanup
Aug 24, 2021

Conversation

QuLogic
Copy link
Member

PR Summary

Fromhttps://github.com/matplotlib/matplotlib/pull/13306/files/c3772ae037c5a2c7614013a9c36954675c5d9de0#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [n/a] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@tacaswelltacaswell self-requested a reviewAugust 24, 2021 02:01
@tacaswell
Copy link
Member

We did not catch this because we do not test Qt on windows or codecov is behaving a bit wonky. I'm going to try pushing a commit adding pyqt to appveyor.

@QuLogic
Copy link
MemberAuthor

pywin32 is installed on both CIs, so we wouldn't have seen anything wrong, I think.

@tacaswell
Copy link
Member

If this fails on appveyor, I am 👍🏻 on@QuLogic force-pushing my commit out of existence and self-merging.

@QuLogicQuLogic marked this pull request as draftAugust 24, 2021 03:37
@QuLogicQuLogic marked this pull request as ready for reviewAugust 24, 2021 04:16
@QuLogicQuLogic merged commit6d394df intomatplotlib:masterAug 24, 2021
@QuLogicQuLogic deleted the qt-interrupt-cleanup branchAugust 24, 2021 05:28
@QuLogicQuLogic mentioned this pull requestAug 26, 2021
4 tasks
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestAug 26, 2021
As it was only needed for the sigint tests. (matplotlib#20883)
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestAug 31, 2021
As it was only needed for the sigint tests. (matplotlib#20883)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

2 participants
@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp