Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Add unit test to catch recurrences of #20822, #20855#20856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

lpsinger
Copy link
Contributor

PR Summary

Add a unit test to automatically catch issues like#20822 and#20855.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@lpsinger
Copy link
ContributorAuthor

Note that the tests for this PR will be expected to fail until#20855 is merged.

@lpsingerlpsingerforce-pushed thegetattr-attributeerror-test branch 2 times, most recently from4df44f6 toa5da792CompareAugust 18, 2021 16:19
@lpsingerlpsingerforce-pushed thegetattr-attributeerror-test branch froma5da792 toe0ae4b0CompareAugust 18, 2021 16:25
@lpsingerlpsingerforce-pushed thegetattr-attributeerror-test branch frome0ae4b0 to79a0a33CompareAugust 19, 2021 02:17
@lpsinger
Copy link
ContributorAuthor

This should pass now that#20855 has been merged.

@tacaswell
Copy link
Member

I cherry-picked this commit into#20857 for a belt-and-suspenders approach.

@QuLogic
Copy link
Member

Merged into#20857.

@lpsingerlpsinger deleted the getattr-attributeerror-test branchAugust 20, 2021 22:14
@tacaswell
Copy link
Member

Thanks@lpsinger ! I made the assumption you would not mind if we cherry-picked your commit to the other PR (and you are not counting merged PRs for a metric someplace), hope you are OK with this.

@lpsinger
Copy link
ContributorAuthor

Of course, no problem!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

3 participants
@lpsinger@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp