Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Try to install the Noto Sans CJK font#20851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
66965e0 tofd2d801CompareZen Hei seemspackaged for Ubuntu, but in Universe, Not sure if we need to do something special to allow installing it. |
The SourceForge download of Zen Hei sometimes fails, so this was probably not a good idea. Google's Noto fonts seem to be better packaged in various systems, so perhaps something like Noto Sans CJK SC could be more useful. For context: some of the new font changes by@aitikgupta crash on my computer (an M1 Mac) but not on his (I believe Linux on x86), so I would like to add a more cross-platform test with a CJK font and see if we can replicate the crash in CI. |
c04d923 toa71185cCompareOn Linux and Mac. Add a font_manager test that loads the font anduses it. This could be useful in testing the multi-font support(matplotlib#20740 etc).I couldn't get the font installed on Windows. There is a Chocolateyinstaller that installs all of the Noto fonts, which takes a reallylong time to run.
I'm giving up on Windows - the Chocolatey package installs all of the Noto fonts and takes half an hour to do it, and my PowerShell skills are not enough to install just one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this can be a good validation for testing the font fallback.
If we do keep this, do we also need to keep installing ZenHei for CI (on Linux) as well?
Noto CJK could potentially replace it right? (I'll do a local installation to test out the actual difference between number of glyphs)
Uh oh!
There was an error while loading.Please reload this page.
On Linux and Mac. Add a font_manager test that loads the font and uses it. This could be useful in testing the multi-font support (#20740 etc).
I couldn't get the font installed on Windows. There is a Chocolatey installer that installs all of the Noto fonts, which takes a really long time to run.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).