Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BUG: __getattr__ must raise AttributeError if name not found#20822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
PRmatplotlib#20733 added module-level `__getattr__` functions to severalmodules. All of the functions with the exception of the one in`matplotlib.style.core` had a terminal `raise AttributeError` tohandle unmatched attributes.The omission in `matplotlib.style.core` was probablyunintentional; it results in confusing and buggy behaviorsuch as:```pycon>>> import matplotlib.style.core>>> if hasattr(matplotlib.style.core, '__warningregistry__'):... del matplotlib.style.core.__warningregistry__...Traceback (most recent call last): File "<stdin>", line 2, in <module>AttributeError: __warningregistry__```This causes problems in the unit tests for astropy affiliatedpackages. Seeastropy/astropy#12038.
9 tasks
QuLogic approved these changesAug 10, 2021
jklymak approved these changesAug 10, 2021
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 18, 2021
PRmatplotlib#20806 added another instance of a module-level `__getattr__`function that was missing a final `raise AttributeError` to catchunknown attributes. This is the same kind of bug asmatplotlib#20822.See alsoastropy/astropy#12038.
7 tasks
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 18, 2021
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 18, 2021
7 tasks
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 18, 2021
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 18, 2021
7 tasks
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 18, 2021
lpsinger added a commit to lpsinger/matplotlib that referenced this pull requestAug 19, 2021
tacaswell pushed a commit to anntzer/matplotlib that referenced this pull requestAug 20, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR#20733 added module-level
__getattr__functions to several modules. All of the functions with the exception of the one inmatplotlib.style.corehad a terminalraise AttributeErrorto handle unmatched attributes.The omission in
matplotlib.style.corewas probably unintentional; it results in confusing and buggy behavior such as:This causes problems in the unit tests for astropy affiliated packages. Seeastropy/astropy#12038.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).