Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make test_change_epoch more robust.#20817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The epoch is set by explicitly calling `mdates.set_epoch`, or implicitlyset to the default by `mdates.get_epoch` (which is also called whenconverting datetimes.)However, when running tests in parallel, there is no guarantee that anyother call to `[gs]et_epoch` might have been made to lock it in, so weneed to do that explicitly.
jklymak approved these changesAug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure you need the firstget_epoch
But that's the point; it wouldn't be locked in and raise without it. |
timhoffm approved these changesAug 10, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 10, 2021
QuLogic added a commit that referenced this pull requestAug 10, 2021
…817-on-v3.4.xBackport PR#20817 on branch v3.4.x (Make test_change_epoch more robust.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The epoch is set by explicitly calling
mdates.set_epoch, or implicitly set to the default bymdates.get_epoch(which is also called when converting datetimes.)However, when running tests in parallel, there is no guarantee that any other call to
[gs]et_epochmight have been made to lock it in, so we need to do that explicitly.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).