Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: Rename callbacksSM to callbacks#20799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromgreglucas:rename-callbacksSM
Aug 9, 2021

Conversation

greglucas
Copy link
Contributor

PR Summary

This makes the code more consistent throughout with objects having acallbacks attribute, rather than associating a name with them on the end and using camelCase.

First noticed by@timhoffm in#19553 (comment)

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

This makes the code more consistent throughout with objectshaving a `callbacks` attribute, rather than associating a namewith them on the end.
@QuLogicQuLogic added this to thev3.5.0 milestoneAug 9, 2021
@QuLogicQuLogic merged commitd77783b intomatplotlib:masterAug 9, 2021
@greglucasgreglucas deleted the rename-callbacksSM branchAugust 9, 2021 21:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

3 participants
@greglucas@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp