Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed typo in _constrained_layout.py (#20782)#20786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

sandipanpanda
Copy link
Contributor

@sandipanpandasandipanpanda commentedAug 3, 2021
edited
Loading

PR Summary

Fixed#20782. Inhttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/_constrained_layout.py#L304

fixed typo

if fig._supylabel is not None and fig._supxlabel.get_in_layout():

to

if fig._supylabel is not None and fig._supylabel.get_in_layout():

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Inhttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/_constrained_layout.py#L304    if fig._supylabel is not None and fig._supxlabel.get_in_layout():    should be    if fig._supylabel is not None and fig._supylabel.get_in_layout():
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@jklymakjklymak added the topic: geometry managerLayoutEngine, Constrained layout, Tight layout labelAug 3, 2021
@jklymakjklymak modified the milestones:v3.5.0,v3.4.3Aug 3, 2021
@jklymakjklymak merged commit2c3bc26 intomatplotlib:masterAug 3, 2021
@jklymak
Copy link
Member

Thanks@sandipanpanda !

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 3, 2021
jklymak added a commit that referenced this pull requestAug 3, 2021
…786-on-v3.4.xBackport PR#20786 on branch v3.4.x (Fixed typo in _constrained_layout.py (#20782))
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@story645story645story645 approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
topic: geometry managerLayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.4.3
Development

Successfully merging this pull request may close these issues.

[Bug]: _supylabel get_in_layout() typo?
3 participants
@sandipanpanda@jklymak@story645

[8]ページ先頭

©2009-2025 Movatter.jp