Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixed typo in _constrained_layout.py (#20782)#20786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Inhttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/_constrained_layout.py#L304 if fig._supylabel is not None and fig._supxlabel.get_in_layout(): should be if fig._supylabel is not None and fig._supylabel.get_in_layout():
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping@matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
Thanks@sandipanpanda ! |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Fixed#20782. Inhttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/_constrained_layout.py#L304
fixed typo
if fig._supylabel is not None and fig._supxlabel.get_in_layout():
to
if fig._supylabel is not None and fig._supylabel.get_in_layout():
PR Checklist
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).flake8
on changed files to check).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).