Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Dedupe handling of mouse buttons in macos backend.#20778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AFAICT `mouseDown()` and friends already check `[event type]` andcorrectly handle right/middle button events, so the other event handlerscan just defer to them.The point of the deduplication is so that future event rearchitectingdoesn't have to repeat loads of keyboard-modifiers handling code in eachof these handlers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Interactive zoom-out works on my Macbook Pro (I don't have a right mouse button but dragging with two fingers is equivalent).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This also worked for me on macos. I had a right button that zoomed out as expected.
AFAICT
mouseDown()
and friends already check[event type]
andcorrectly handle right/middle button events, so the other event handlers
can just defer to them.
The point of the deduplication is so that future event rearchitecting
(subsequent to#16931 and fixing#6159)
doesn't have to repeat loads of keyboard-modifiers handling code in each
of these handlers.
I don't actually have a mac to test this :-) so it would be nice if
someone could check if e.g. interactive zoom-out (by drawing a rubberband
with a right click) still works fine.
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).