Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dedupe handling of mouse buttons in macos backend.#20778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greglucas merged 1 commit intomatplotlib:masterfromanntzer:macosmousebutton
Aug 3, 2021

Conversation

anntzer
Copy link
Contributor

AFAICTmouseDown() and friends already check[event type] and
correctly handle right/middle button events, so the other event handlers
can just defer to them.

The point of the deduplication is so that future event rearchitecting
(subsequent to#16931 and fixing#6159)
doesn't have to repeat loads of keyboard-modifiers handling code in each
of these handlers.

I don't actually have a mac to test this :-) so it would be nice if
someone could check if e.g. interactive zoom-out (by drawing a rubberband
with a right click) still works fine.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

AFAICT `mouseDown()` and friends already check `[event type]` andcorrectly handle right/middle button events, so the other event handlerscan just defer to them.The point of the deduplication is so that future event rearchitectingdoesn't have to repeat loads of keyboard-modifiers handling code in eachof these handlers.
Copy link
Member

@jkseppanjkseppan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Interactive zoom-out works on my Macbook Pro (I don't have a right mouse button but dragging with two fingers is equivalent).

anntzer reacted with thumbs up emoji
Copy link
Contributor

@greglucasgreglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This also worked for me on macos. I had a right button that zoomed out as expected.

@greglucasgreglucas merged commitd0cc394 intomatplotlib:masterAug 3, 2021
@anntzeranntzer deleted the macosmousebutton branchAugust 3, 2021 22:45
@QuLogicQuLogic added this to thev3.5.0 milestoneAug 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkseppanjkseppanjkseppan approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@jkseppan@greglucas@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp