Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC/TST make circle faster#20727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

PR Summary

According to#20720 (comment), compressing images takes about 15% of the build time, as does the uncollapsed navigation, so don't do those costly steps if running Circle CI.

Note that the pydata-sphinx-theme is still quite slow, taking 50% more time than the bare build without the other two options.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak
Copy link
MemberAuthor

This worked. Build was 30 minutes, but Circle seems slow currently. Upload was 5 minutes.

Compare to the build for#20725 which took 47 minutes and 7 minutes to upload. I think compressing the images doesn't make up for all the extra verbiage in every html file from the navigation.

@jklymakjklymak marked this pull request as ready for reviewJuly 23, 2021 23:10
@tacaswelltacaswell added this to thev3.5.0 milestoneJul 23, 2021
@tacaswell
Copy link
Member

codecov still saw an upload from appveyor ?! There are some mysteries not worth chasing down...

@tacaswelltacaswell merged commit88f53b1 intomatplotlib:masterJul 23, 2021
@tacaswell
Copy link
Member

Thanks for pushing on this@jklymak !

jklymak reacted with thumbs up emoji

@jklymakjklymak deleted the doc-make-circle-faster branchJuly 23, 2021 23:15
@jklymakjklymak mentioned this pull requestJul 24, 2021
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

2 participants
@jklymak@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp