Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Doc test no pydata#20720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Closed

Conversation

jklymak
Copy link
Member

PR Summary

DO NOT MERGE..

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

making sure it won't be merged ;)

@jklymak
Copy link
MemberAuthor

  • OK, so took 26 minutes with the pydata theme commented out.
  • Other recent builds took 40 minutes

I'd say the pydata theme is definitely slowing things down

@jklymak
Copy link
MemberAuthor

The point raised on gitter aboutoptipng is a good one. Trying with no compressing of thumbnails.

@jklymak
Copy link
MemberAuthor

  • turning off compression dropped the build time to 18 minutes (pydata theme still off)

@jklymak
Copy link
MemberAuthor

(BTW, thanks@larsoner for the skip commands!)

@jklymak
Copy link
MemberAuthor

Pinning pydata_theme fails, and took 48 minutes to do so. Of course its possible the failure is causing the slowness, but I would guess not.

@jklymak
Copy link
MemberAuthor

18c4fde (collapse navigation = True and no compression) took 26 minutes. So collapsing the navigation helps substantially.

@larsoner
Copy link
Contributor

Fromhttps://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/configuring.html#configure-the-navigation-depth-and-collapsing-of-the-sidebar it looks like the default depth is 4, maybe restricting to 2 would be faster enough?

html_theme_options = {  "navigation_depth": 2}

@larsoner
Copy link
Contributor

(or maybe this won't speed things up at all, not sure...)

@jklymak
Copy link
MemberAuthor

Ha, well that one took over an hour. I'm nit sure I trust circle to do these tests, so I guess I'll do them on a local machine....

@jklymak
Copy link
MemberAuthor

OK, here is the results of tests for my machine:

all sphinx 3.5.3sphinx-gallery                 0.9.0.dev0 serial build (no parallel)make clean each timemake htmlcompress_images: ('thumbnails', 'images'),collapse_navigation: Falsepydata-sphinx-theme:            0.6.3commit: masterresult: 2010.13s  = 33.5 minutescompress_images: ('thumbnails', 'images'),collapse_navigation: Truepydata-sphinx-theme:            0.6.3commit: masterresult: 1639.42s  = 27.3 minutescompress_images: Off!collapse_navigation: Truepydata-sphinx-theme:            0.6.3commit: masterresult: 1322.72s  = 22 minutescompress_images: Truecommit: 7d77bb9670  (no theme)result: 1232.57s = 20.54 minutescompress_images: Falsecommit: 7d77bb9670  (no theme)result: 911.00s = 15.2 minutes

So in sum the breakdown is basically:

  • fastest = 15 minutes
  • new theme = +7 minutes
  • compress images = +5 minutes
  • uncollapsed navigation = +5 minutes

Is there any reason to compress the images on CI?

We can run CI with the navigation collapsed. Those combined should get us from 33 minutes to 22 or 23 minutes. Thats still 50% slower than without the new theme, but...

@timhoffm
Copy link
Member

Thanks@jklymak for doing all the tests!

Is there any reason to compress the images on CI?

I don't think there is a strong reason. It makes the devdocs upload larger and viewing the devdocs costs more bandwidth, but that's bearable if the built is significantly faster.

@jklymakjklymak mentioned this pull requestJul 23, 2021
7 tasks
@jklymak
Copy link
MemberAuthor

.. sure well lets see; if it adds 5 minutes to the upload time, its not worth doing ;-)

@jklymak
Copy link
MemberAuthor

Closed by#20727

@jklymakjklymak deleted the doc-test-no-pydata branchJuly 24, 2021 03:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jklymak@larsoner@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp