Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Describe possible need for loading the 'lmodern' package when using PGF files#20708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 6 commits intomatplotlib:masterfromuihsnv:lmodern-doc
Oct 16, 2021

Conversation

uihsnv
Copy link
Contributor

@uihsnvuihsnv commentedJul 21, 2021•
edited
Loading

PR Summary

The PR adds a suggestion to use thelmodern package when using.pgf files generated by Matplotlib. Changes are made both to a documentation page as well as the commented preamble printed in every generated.pgf file.

This was found to be necessary specifically in the case of a math-bold-faced, uppercase Greek letter 'delta' was not rendered when thelmodern package was not loaded.

See discussion for more details:
https://matrix.to/#/!BXmyZMTnRjWJldDRLV:gitter.im/$M7KxLQuyUosx2byFxIsKJE8QS_14NRiWqmmlb6nSIfE?via=gitter.im&via=matrix.org

PR Checklist

  • [N/A] Has pytest style unit tests (andpytest passes).
  • [N/A] IsFlake 8 compliant (runflake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • [N/A] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@anntzer
Copy link
Contributor

I would have thought(?) that this is rather a standard TeX limitation (https://texfaq.org/FAQ-boldgreek,https://tex.stackexchange.com/questions/595) and may not warrant a specific doc entry on our side?

@uihsnv
Copy link
ContributorAuthor

@anntzer Those links describe a related issue of\mathbf{} not sufficiently emboldening some Greek font. But here, the very font was missing when compiling without thelmodern package.

@jklymak
Copy link
Member

I think the mystery here is what combination of factors do you need to trigger this problem. I've never come across a LaTeX install that requires\include{lmodern}for most typesetting needs.

anntzer reacted with thumbs up emoji

@tacaswell
Copy link
Member

On one hand, that we have this issue is super weird (and as discussed on gitter it seems to depend on which LaTeX engine you use) and may actually be caused by something inside of the pgf package.

Given that this work around does fix the problem, I am in favor of including a note about this and opening a new issue in the spirit of "sort out when / why / iflmodern is actually needed".

timhoffm reacted with thumbs up emoji

@tacaswelltacaswell marked this pull request as ready for reviewOctober 13, 2021 19:52
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@timhoffmtimhoffm merged commit3e9425f intomatplotlib:masterOct 16, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 16, 2021
timhoffm added a commit that referenced this pull requestOct 16, 2021
…708-on-v3.5.xBackport PR#20708 on branch v3.5.x (Describe possible need for loading the 'lmodern' package when using PGF files)
tacaswell pushed a commit that referenced this pull requestOct 20, 2021
Describe possible need for loading the 'lmodern' package when using PGF files
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@jklymakjklymakjklymak left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

6 participants
@uihsnv@anntzer@jklymak@tacaswell@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp