Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

BUG: pass kwargs to TimedAnimation#2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdboom merged 1 commit intomatplotlib:masterfromjakevdp:anim_fix
May 28, 2013

Conversation

jakevdp
Copy link
Contributor

A quick bug fix to pass keyword arguments on to the parent class.

@jakevdp
Copy link
ContributorAuthor

Another thing: throughout this file, initialization functions are called directly, rather than withsuper(). Is there a reason for avoidingsuper here, or should that be changed?

@pelson
Copy link
Member

Thanks@jakevdp. We should apply this to thev1.3.x branch.@mdboom - shall we cherry pick the commit, or resubmit a PR (this is a general question about the maintenance branch I guess...).

Another thing: throughout this file, initialization functions are called directly, rather than with super(). Is there a reason for avoiding super here, or should that be changed?

I think I remember a discussion between@dopplershift and@jdh2358 regarding issues with multiple inheritance (in#1012 I think) and various__init__s not being called when they were designed to be.

👍 from me

@mdboom
Copy link
Member

@pelson: Yes, this should be backported to 1.3.x, and possibly 1.2.x (haven't yet checked its applicability there). I think merging to master and then cherry-picking the merge to the branches after is fine (rather than resubmitting PRs).

As persuper -- yes, with multiple inheritance being used here, it is safer to not usesuper. And in general, I prefer not to usesuper on the grounds of explicit being better than implicit, though it doesn't require care to update when moving classes around the heirarchy, but that's a rare occurrence.

mdboom added a commit that referenced this pull requestMay 28, 2013
BUG: pass kwargs to TimedAnimation
@mdboommdboom merged commit220306b intomatplotlib:masterMay 28, 2013
mdboom added a commit that referenced this pull requestMay 28, 2013
BUG: pass kwargs to TimedAnimation
mdboom added a commit that referenced this pull requestMay 28, 2013
BUG: pass kwargs to TimedAnimation
@dmcdougall
Copy link
Member

As per super -- yes, with multiple inheritance being used here, it is safer to not use super. And in general, I prefer not to use super on the grounds of explicit being better than implicit, though it doesn't require care to update when moving classes around the heirarchy, but that's a rare occurrence.

Also not that the call signature ofsuper has changed in Python 3.3, I think. I'm not sure if this is something 2to3 handles.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.x
Development

Successfully merging this pull request may close these issues.

4 participants
@jakevdp@pelson@mdboom@dmcdougall

[8]ページ先頭

©2009-2025 Movatter.jp