Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Small simplifications to FixedAxisArtistHelper.#20638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:faah
Jul 17, 2021

Conversation

anntzer
Copy link
Contributor

  • change_tick_coords has never been used by any other function or in any
    example in the library's history, and is a custom API not even present
    on other AxisArtistHelpers, so deprecate it.
  • _limits_inverted is only used in get_tick_iterators, so one can just
    test limits inversion there instead of carrying one bit of state
    around.

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@timhoffm
Copy link
Member

I think I fixed the doc build failue as part of#20632. Please rebase on master.

- change_tick_coords has never been used by any other function or in any  example in the library's history, and is a custom API not even present  on other AxisArtistHelpers, so deprecate it.- _limits_inverted is only used in get_tick_iterators, so one can just  test limits inversion there instead of carrying one bit of state  around.
@timhoffmtimhoffm merged commit57489bf intomatplotlib:masterJul 17, 2021
@anntzeranntzer deleted the faah branchJuly 17, 2021 21:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp