Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Emit non BMP chars as XObjects in PDF#20633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:masterfromsauerburger:pdf-non-bmp-chars
Jul 22, 2021

Conversation

sauerburger
Copy link
Member

@sauerburgersauerburger commentedJul 12, 2021•
edited
Loading

PR Summary

Closes#20616

This PR address#20616 and emits Type 42 chars from beyond the Basic Multilingual Plane as XObjects, similar to the treatment of multi-byte chars in Type 3 fonts.

This PR builds on top of#20615.

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

@sauerburgersauerburger changed the titlePdf non bmp charsEmit non BMP chars as XObjects in PDFJul 12, 2021
Copy link
Contributor

@aitikguptaaitikgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is close to what@anntzer mentioned by splitting characters into 'multi-bytes' for Type 42 as well (briefly during the call and on#18191).

Looks good! 🎉

Test that character beyond the Basic Multilingual Plane are supported in PDFfiles with Type 42 fonts. The example tests STIX Sans math chars and a charfrom an old script.
Currently, the CID maps only support 2-byte fixed-width characters. Unicodepoints beyond the Basic Multilingual Plane cannot be used. This comment followsthe strategy taken for Type 3 fonts. Any char with a code point > 65535 isemitted as an XObject.
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm approving in lieu of@aitikgupta, not because I understand the font handling here.

@QuLogicQuLogic merged commitbd127f3 intomatplotlib:masterJul 22, 2021
@sauerburgersauerburger mentioned this pull requestJul 22, 2021
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

@aitikguptaaitikguptaaitikgupta approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Type 42 chars beyond BMP not displayed in PDF
4 participants
@sauerburger@QuLogic@jklymak@aitikgupta
[8]ページ先頭
©2009-2025 Movatter.jp