Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use ticklabels([]) instead of ticklabels('')#20632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Technically not a doc-only change because I also updated the tests. |
| @@ -68,8 +68,8 @@ def doall(): | |||
| plt.gca().set_ylim(0., 1.) | |||
| plt.gca().set_title("Matplotlib's math rendering engine", | |||
| color=mpl_grey_rvb, fontsize=14, weight='bold') | |||
| plt.gca().set_xticklabels("", visible=False) | |||
| plt.gca().set_yticklabels("", visible=False) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is visible=False doing here?/is it okay that it's dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It sets all of the 0 created ticklabels to invisible 🙃 , i.e. does nothing.
The string variant is not supported according to the docstring. It'sonly working by accident.
Self-merged based on the positive review. |
The string variant is not supported according to the docstring. It's
only working by accident due to the list comprehension in
matplotlib/lib/matplotlib/axis.py
Line 1705 in30cbdf7