Hi@yacth. Thanks for contributing. As you can see, some of your tests are failing. To begin with, the test is complaining about formatting - clik on Linting/flake8 (pull_request) for more details. From thecontributing documents it recommends to do the following to your code:

python -m pip install flake8flake8 /path/to/module.py

which ensures formatting is done correctly. Secondly, its also complaining about needing tests for the added features, as per the website linked above:

Changes (both new features and bugfixes) should have good test coverage. See Testing for more details.
So what you have added needs to be covered by tests.

Its also important to make sure you run some tests before to make sure your changes are not breaking other features, seetesting. For the implementation details, you will have to wait for some of the other developers to review it. But it greatly helps to make sure the previous tests passed, so the conversation can focus on implementation itself.

Hi@yacth. Thanks for contributing. As you can see, some of your tests are failing. To begin with, the test is complaining about formatting - clik on Linting/flake8 (pull_request) for more details. From thecontributing documents it recommends to do the following to your code:

python -m pip install flake8flake8 /path/to/module.py

which ensures formatting is done correctly. Secondly, its also complaining about needing tests for the added features, as per the website linked above:

Changes (both new features and bugfixes) should have good test coverage. See Testing for more details.
So what you have added needs to be covered by tests.

Its also important to make sure you run some tests before to make sure your changes are not breaking other features, seetesting. For the implementation details, you will have to wait for some of the other developers to review it. But it greatly helps to make sure the previous tests passed, so the conversation can focus on implementation itself.

Thank you for your review.

Actually since it is rewritting the original feature in another way I thought that letting the old tests should be good enough.
What do you think about it ?

@yacth if the old tests fail then you changed the behaviour with your changes and the new code needs to be fixed, or you need to argue that the changes you made are an improvement and rewrite the tests.

I am working on the code, but I am stuck.
If someone can review what I have done and help me getting unblocked.

I am trying some testings using a simple code :

importmatplotlib.scaleasscalescale.PowerScale(10,0.5)

I get the following error :

TypeError:__init__()takes2positionalargumentsbut3weregiven

Which I don't understand.

But by running what is inside line by line on my local environment I don't have a failure, I don't get it:

this might be silly, but can you double check which version of matplotlib and which branch you're testing against?

@yacth, this is looking close. Suggest you rebase on master, that should fix your build error.

This does need tests and documentation as well if you are up for it. It is hard to tell if it is working without those.

@yacth, this is looking close. Suggest you rebase on master, that should fix your build error.

This does need tests and documentation as well if you are up for it. It is hard to tell if it is working without those.

I did a rebase, hope this will solve the failing tests.

Sure I will investigate the tests.

But first I have some questions about thelocators andformatters for here I still have something to change, because I used "default" values .

@yacth I've not been following this PR closely. Did you spell out the locator/formatter issues? I can imagine they are a bit thorny as there is not a natural locator for the Power Scale. Perhaps best so see how it has been used in other contexts and copy.

Hi@yacth - are you interested in continuing this work? If so, please mark the PR as ready for review and let us know if you need help with the rebase, we haveinstructions for that here. Thanks!