Added an example to the gallery for discussion regarding#19515. All that needs to happen in each event is to modify the colorbar norm vmin and vmax, although the particular interactivity that was desired in#19515 would require a little more creativity in the callbacks.

Hoping for feedback as to:

whether to actually include in gallery
style of new gallery page
code review

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

richardsheridan added topic: color/colorbar Documentation/new page labels

Jun 19, 2021

timhoffm reviewed

Jun 20, 2021

View reviewed changes

examples/userdemo/colormap_interactive_adjustment.pyShow resolvedHide resolved

examples/userdemo/colormap_interactive_adjustment.py OutdatedShow resolvedHide resolved

Copy link

Member

timhoffm commentedJun 20, 2021

BTW thanks for taking the time to put this example together!

richardsheridan mentioned this pull request

Jun 22, 2021

ColorbarAxes is an imperfect proxy for the Axes passed to Colorbar#20479

Closed

richardsheridan marked this pull request as draft

June 22, 2021 00:51

Copy link

ContributorAuthor

richardsheridan commentedJun 22, 2021

I feel#20479 blocks this PR so marking as draft until resolved.

Copy link

ContributorAuthor

richardsheridan commentedJun 22, 2021

Also something about the newColorbarAxes detaches the mouse event xdata and ydata from the data range, so this only coincidentally worked since the range of the data was 0..1, another blocker.

richardsheridan added2 commits

July 7, 2021 23:33

add interactive colorbar example to gallery

6249be7

respond to code reviews, use better data source

19b9523

richardsheridan force-pushed theinteractive_colorbar branch from46efae8 to19b9523Compare

July 8, 2021 14:19

richardsheridan marked this pull request as ready for review

July 8, 2021 14:20

Copy link

ContributorAuthor

richardsheridan commentedJul 8, 2021

Unblocked by#20501, thanks for everyone's help there! (Somehow I didn't get any notifications about that PR?)

Copy link

Member

timhoffm commentedJul 8, 2021

flake8:

./examples/userdemo/colormap_interactive_adjustment.py:51:80: E501 line too long (87 > 79 characters)

richardsheridan added3 commits

July 8, 2021 16:37

flake8

ba252f9

Initialize norm and comment on how the axes are synced

ae8e76f

notebook cell layout

adff2ca

Copy link

Member

jklymak commentedJul 21, 2021

Maybe I'm doing something wrong, but this only works for one click for me and then the colorbar stops responding. Is that expected, or am I doing something wrong?