NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Remove remaining 3.3 deprecations#20465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 8 commits intomatplotlib:masterfromQuLogic:remove-33-deprecations

Jul 1, 2021

Merged

Remove remaining 3.3 deprecations#20465

timhoffm merged 8 commits intomatplotlib:masterfromQuLogic:remove-33-deprecations

Jul 1, 2021

Conversation

Copy link

Member

PR Summary

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
[n/a] New features are documented, with examples if plot related.
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
[n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic added topic: widgets/UI topic: animation topic: path handling Maintenance topic: transforms and scales labels

Jun 19, 2021

QuLogic added this to thev3.5.0 milestone

Jun 19, 2021

QuLogic force-pushed theremove-33-deprecations branch from981040d tof0aa57bCompare

June 19, 2021 09:04

Copy link

MemberAuthor

QuLogic commentedJun 19, 2021

OK, there are actually two more left, the global colour map dictionary, and global cmap modification. The latter is marked for removal in 3.6, but I'm not sure about the former.

Copy link

MemberAuthor

QuLogic commentedJun 19, 2021

Also, thecbook.get_sample_data deprecation never mentioned a removal version...

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	* ``animation.html_args``rcParam
	*The rcParam``animation.html_args``has been removed.

IMHO for clarity, we should take the effort and make full sentences. Also in the following bullet points.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm a bit lazier here because a) this is in the removal section, so it's implied, and b) I re-edit these when I put together final release notes and they may or may not be re-grouped, and then will get an overall sentence then.