NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

PGF: Clip lines/markers to maximum LaTeX dimensions.#20410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 1 commit intomatplotlib:masterfromQuLogic:pgf-clip

Jun 11, 2021

Merged

PGF: Clip lines/markers to maximum LaTeX dimensions.#20410

jklymak merged 1 commit intomatplotlib:masterfromQuLogic:pgf-clip

Jun 11, 2021

Conversation

Copy link

Member

PR Summary

This has been open for many years without any change to LaTeX, so it seems unlikely they are going to change how their parsing works.

Note that this does add clipping for filled paths, which we normally don't do, but it's so so far away, I don't think it'll be a problem.

Fixes#4482.

PR Checklist

Has pytest style unit tests (andpytest passes).
IsFlake 8 compliant (runflake8 on changed files to check).
[n/a] New features are documented, with examples if plot related.
[n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
[n/a] Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
[n/a] New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
[n/a] API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

PGF: Clip lines/markers to maximum LaTeX dimensions.

447e578

This has been open for many years without any change to LaTeX, so itseems unlikely they are going to change how their parsing works.Fixesmatplotlib#4482.

QuLogic added the backend: pgf label

Jun 11, 2021

QuLogic added this to thev3.5.0 milestone

Jun 11, 2021

anntzer approved these changes

Jun 11, 2021

View reviewed changes

jklymak approved these changes

Jun 11, 2021

View reviewed changes

Copy link

Member

jklymak commentedJun 11, 2021

I'm surprised that is all there is to it, but if this helps...

jklymak merged commit103c3ab intomatplotlib:master

Jun 11, 2021

QuLogic deleted the pgf-clip branch

June 11, 2021 20:16

jklymak mentioned this pull request

Nov 22, 2021

[Bug]: Saving as PGF results in invalid code (fails when including it in Latex document)#21708

Closed

Copy link

@QuLogic Thank you for this fix. However, it is not complete. If I understand correctly, you have clipped markers (indraw_markers) and lines (in_print_pgf_path) only, but there are still some unclipped\pgfsys@transformshift writings. For instance,fill_between with hatching usesthis line and can lead to the sameDimension too large error. Could you apply the same clipping technique for that part of thedraw_path function?