Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Cleanup axisartist in preparation for future changes.#20206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
axisartist stores in .grid_info various intermediary calculations usedto draw gridlines (which may be curved) and ticks. It may be helpful tochange the internal representation of this info in the future (e.g.using Paths directly rather than x, y arrays which have to becontinuously packed and unpacked), but doing so means that the attributeshould become private first.Also remove the private _get_line_path, which was added in008b765 butapparently never ever used (we can always reintroduce something likethat if needed).
QuLogic approved these changesMay 11, 2021
timhoffm approved these changesMay 12, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
axisartist stores in .grid_info various intermediary calculations used
to draw gridlines (which may be curved) and ticks. It may be helpful to
change the internal representation of this info in the future (e.g.
using Paths directly rather than x, y arrays which have to be
continuously packed and unpacked), but doing so means that the attribute
should become private first.
Also remove the private _get_line_path, which was added in008b765 but
apparently never ever used (we can always reintroduce something like
that if needed).
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).