Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix resetting grid visibility#20161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Actually, there were two issues:- 'gridOn' state should always be contained in the _tick_kw settings. This is needed because we support toggling via grid() and thus need to be able to query the state. Therefore, the _tick_kw dicts must be resetted instead of cleared.- grid(some_kwarg=...) i.e. with b=None and keywords must be treated explicitly as b=True as the docs already propose.Closesmatplotlib#20149.
QuLogic approved these changesMay 5, 2021
@anntzer you worked on this most recently I think. Can you review? |
anntzer approved these changesMay 6, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 6, 2021
7 tasks
QuLogic added a commit that referenced this pull requestMay 6, 2021
…161-on-v3.4.xBackport PR#20161 on branch v3.4.x (Fix resetting grid visibility)
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, there were two issues:
This is needed because we support toggling via grid() and thus need
to be able to query the state. Therefore, the _tick_kw dicts must be
resetted instead of cleared.
explicitly as b=True as the docs already propose.
Closes#20149.