Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix resetting grid visibility#20161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 1 commit intomatplotlib:masterfromtimhoffm:grid-reset
May 6, 2021
Merged

Conversation

timhoffm
Copy link
Member

Actually, there were two issues:

  • 'gridOn' state should always be contained in the _tick_kw settings.
    This is needed because we support toggling via grid() and thus need
    to be able to query the state. Therefore, the _tick_kw dicts must be
    resetted instead of cleared.
  • grid(some_kwarg=...) i.e. with b=None and keywords must be treated
    explicitly as b=True as the docs already propose.

Closes#20149.

@timhoffmtimhoffm added this to thev3.4.2 milestoneMay 4, 2021
Actually, there were two issues:- 'gridOn' state should always be contained in the _tick_kw settings.  This is needed because we support toggling via grid() and thus need  to be able to query the state. Therefore, the _tick_kw dicts must be  resetted instead of cleared.- grid(some_kwarg=...) i.e. with b=None and keywords must be treated  explicitly as b=True as the docs already propose.Closesmatplotlib#20149.
@jklymakjklymak assignedanntzer and unassignedanntzerMay 6, 2021
@jklymakjklymak requested a review fromanntzerMay 6, 2021 18:00
@jklymak
Copy link
Member

@anntzer you worked on this most recently I think. Can you review?

@anntzeranntzer merged commit2b8590c intomatplotlib:masterMay 6, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMay 6, 2021
@timhoffmtimhoffm deleted the grid-reset branchMay 6, 2021 18:19
QuLogic added a commit that referenced this pull requestMay 6, 2021
…161-on-v3.4.xBackport PR#20161 on branch v3.4.x (Fix resetting grid visibility)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.2
Development

Successfully merging this pull request may close these issues.

KeyError: 'gridOn' in axis.py when axis.tick_params() is used with reset = True
4 participants
@timhoffm@jklymak@QuLogic@anntzer

[8]ページ先頭

©2009-2025 Movatter.jp