Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix removal of shared polar axes.#20009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There's really two separate fixes here:- Move isDefault_{maj,min}{loc,fmt} tracking to the Ticker instances, where they logically belong (note the previous need to additionally track them manually on axes removal, when that info was tracked on the Axis). This has the side effect of fixing removal of sharex'd polar axes, as ThetaLocators rely on _AxisWrappers which don't have that isDefault attribute. (Note that the patch would have resulted in a net decrease of lines of code if it didn't need to maintain backcompat on isDefault_foos).- Ensure that RadialLocator correctly propagates Axis information to the linear locator it wraps (consistently with ThetaLocator), so that when an axes is removed the wrapped linear locator doesn't stay pointing at an obsolete axes. This, together with the first patch, fixes removal of sharey'd polar axes.
feel free to remilestone |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
thanks@timhoffm :) |
There's really two separate fixes here:
Move isDefault_{maj,min}{loc,fmt} tracking to the Ticker instances,
where they logically belong (note the previous need to additionally
track them manually on axes removal, when that info was tracked on
the Axis). This has the side effect of fixing removal of sharex'd
polar axes, as ThetaLocators rely on _AxisWrappers which don't have
that isDefault attribute. (Note that the patch would have resulted
in a net decrease of lines of code if it didn't need to maintain
backcompat on isDefault_foos).ClosesRemoval of x-shared polar axes causes crash #19988. Split out ofAllow sharing Locators and Formatters across Axises. #13482.
Ensure that RadialLocator correctly propagates Axis information to
the linear locator it wraps (consistently with ThetaLocator), so that
when an axes is removed the wrapped linear locator doesn't stay
pointing at an obsolete axes. This, together with the first patch,
fixes removal of sharey'd polar axes.ClosesRemoval of y-shared polar axes causes crash at draw time #19989.
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).