Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Svn2git#2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Svn2git#2
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Looks good to me, though I think it would make sense to apply my maintenance branch merge first, then merge this to v1.0.x and v1.0.x to master. Or do we need to discuss the branch workflow on the mailing list first to make sure everyone agrees? Also, what's the process for reviewing pull requests? |
I agree: lets apply your maintenance branch merge first. My plan was always to merge this into v1.0.x (hence this pull request) and then merge v1.0.x into master. Concerning the process for reviewing pull requests, I suppose this is it. I think it would be considerate to get everyone who raised objections or concerns to sign off before merging and closing. |
@@ -0,0 +1,41 @@ | |||
.. Known projects | |||
.. PROJECTNAME placeholders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't we have to do something with these lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No - it's confusing - but the 'known projects' were my first pass at including links to mailing lists etc. The current recommended way is via the gitwash_dumper script, that Jarrod ran here. This script writes out a 'this_project.inc' file (see below - at least in my diff listing) then included (with known_projects) in 'links.inc'.
I built the docs with these changes, and I haven't found anything wrong related to the changes. There are a couple of unrelated things to fix later. Also, the gitwash output might be more readable if there were fewer links (e.g., it is merely distracting to have every reference to github be a link), but that is a nit, and certainly doesn't have to be addressed now if at all. |
commit597b6f0Author: Phil Elson <philipelson@hotmail.com>Date: Fri Mar 16 16:35:01 2012 +0000 Changed version which these changes take effect.commit270f291Author: Phil Elson <philipelson@hotmail.com>Date: Wed Feb 29 13:22:03 2012 +0000 Review actions#3commit564e042Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 27 17:18:46 2012 +0000 Review actions#2commit836a459Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 20 15:40:06 2012 +0000 Fixed error raising unittest casecommit677a0edAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 20 13:44:07 2012 +0000 Minor doc changescommitf8021a2Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 20 13:36:11 2012 +0000 Review actionscommit7674dcdAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 18:14:24 2012 +0000 Further tweaks re add_axes.commit89053c5Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 18:03:49 2012 +0000 Reverted polar check.commit1fa7d39Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 17:56:09 2012 +0000 Corrected having not hit git add before committing.commiteb37499Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 17:53:51 2012 +0000 Fixed error messages substitution.commitbd0fd6eAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:56:34 2012 +0000 Matching up diffs with github's diff viewer (newlines).commit53cbea6Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:55:25 2012 +0000 Tidied up branch a little.commit40a0ec9Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:51:33 2012 +0000 reverted projections change.commit756dd8cAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:48:42 2012 +0000 Added documentation, supported add_axes regarding _as_mpl_axes.commitab0615cAuthor: Phil Elson <philipelson@hotmail.com>Date: Tue Jan 31 16:57:50 2012 +0000 Tweaked.commit1a0021bAuthor: Phil Elson <philipelson@hotmail.com>Date: Tue Jan 31 16:08:58 2012 +0000 Class projection support added.
commit597b6f0Author: Phil Elson <philipelson@hotmail.com>Date: Fri Mar 16 16:35:01 2012 +0000 Changed version which these changes take effect.commit270f291Author: Phil Elson <philipelson@hotmail.com>Date: Wed Feb 29 13:22:03 2012 +0000 Review actions#3commit564e042Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 27 17:18:46 2012 +0000 Review actions#2commit836a459Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 20 15:40:06 2012 +0000 Fixed error raising unittest casecommit677a0edAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 20 13:44:07 2012 +0000 Minor doc changescommitf8021a2Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 20 13:36:11 2012 +0000 Review actionscommit7674dcdAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 18:14:24 2012 +0000 Further tweaks re add_axes.commit89053c5Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 18:03:49 2012 +0000 Reverted polar check.commit1fa7d39Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 17:56:09 2012 +0000 Corrected having not hit git add before committing.commiteb37499Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 17:53:51 2012 +0000 Fixed error messages substitution.commitbd0fd6eAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:56:34 2012 +0000 Matching up diffs with github's diff viewer (newlines).commit53cbea6Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:55:25 2012 +0000 Tidied up branch a little.commit40a0ec9Author: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:51:33 2012 +0000 reverted projections change.commit756dd8cAuthor: Phil Elson <philipelson@hotmail.com>Date: Mon Feb 6 16:48:42 2012 +0000 Added documentation, supported add_axes regarding _as_mpl_axes.commitab0615cAuthor: Phil Elson <philipelson@hotmail.com>Date: Tue Jan 31 16:57:50 2012 +0000 Tweaked.commit1a0021bAuthor: Phil Elson <philipelson@hotmail.com>Date: Tue Jan 31 16:08:58 2012 +0000 Class projection support added.
Add Python 3 compatiblity to boilerplate.py
Update to matplotlib:master
BUG : missing manager assignment
# This is the 1st commit message:added interpolate functionaly to fill_betweenx, as in fill_between, enabled through keyword argument interpolate.# This is the commit messagematplotlib#2:added interpolate functionaly to fill_betweenx, as in fill_between, enabled through keyword argument interpolate.
# Das ist die erste Commit-Beschreibung:Test streamplot maxlength feature.# Commit-Beschreibungmatplotlib#2 wird ausgelassen:#Added streamline maxlength test png baseline image.
# Das ist die erste Commit-Beschreibung:Test streamplot maxlength feature.# Commit-Beschreibungmatplotlib#2 wird ausgelassen:#Added streamline maxlength test png baseline image.
# Das ist die erste Commit-Beschreibung:Test streamplot maxlength feature.# Commit-Beschreibungmatplotlib#2 wird ausgelassen:#Added streamline maxlength test png baseline image.
This fixes some possible heap buffer overflows, such as the followingtriggered by our cmmi10.ttf:```ERROR: AddressSanitizer: heap-buffer-overflow on address 0x617000235709 at pc 0x7f95efd3c48a bp 0x7ffe41b6ecc0 sp 0x7ffe41b6ecb0READ of size 1 at 0x617000235709 thread T0 #0 0x7f95efd3c489 in utf16be_to_ascii extern/ttconv/pprdrv_tt.cpp:178#1 0x7f95efd3c489 in Read_name(TTFONT*) extern/ttconv/pprdrv_tt.cpp:339#2 0x7f95efd499ef in read_font(...) extern/ttconv/pprdrv_tt.cpp:1325#3 0x7f95efd4c602 in get_pdf_charprocs(...) extern/ttconv/pprdrv_tt.cpp:1420#4 0x7f95efd35c22 in py_get_pdf_charprocs src/_ttconv.cpp:2170x617000235709 is located 1 bytes to the right of 648-byte region [0x617000235480,0x617000235708)allocated by thread T0 here: #0 0x7f9612262a38 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xdea38)#1 0x7f95efd3b261 in GetTable(TTFONT*, char const*) extern/ttconv/pprdrv_tt.cpp:140```
This fixes some possible heap buffer overflows, such as the followingtriggered by our cmmi10.ttf:```ERROR: AddressSanitizer: heap-buffer-overflow on address 0x617000235709 at pc 0x7f95efd3c48a bp 0x7ffe41b6ecc0 sp 0x7ffe41b6ecb0READ of size 1 at 0x617000235709 thread T0 #0 0x7f95efd3c489 in utf16be_to_ascii extern/ttconv/pprdrv_tt.cpp:178#1 0x7f95efd3c489 in Read_name(TTFONT*) extern/ttconv/pprdrv_tt.cpp:339#2 0x7f95efd499ef in read_font(...) extern/ttconv/pprdrv_tt.cpp:1325#3 0x7f95efd4c602 in get_pdf_charprocs(...) extern/ttconv/pprdrv_tt.cpp:1420#4 0x7f95efd35c22 in py_get_pdf_charprocs src/_ttconv.cpp:2170x617000235709 is located 1 bytes to the right of 648-byte region [0x617000235480,0x617000235708)allocated by thread T0 here: #0 0x7f9612262a38 in __interceptor_calloc (/usr/lib64/libasan.so.4+0xdea38)#1 0x7f95efd3b261 in GetTable(TTFONT*, char const*) extern/ttconv/pprdrv_tt.cpp:140```
# This is the 1st commit message:DOC: expand gridspec tutorial# This is the commit messagematplotlib#2:DOC: fix gs tutorial and remove subplot2grid section
# This is the 1st commit message:bug fix inserted# This is the commit messagematplotlib#2:issue test runs but fails comparison# This is the commit messagematplotlib#3:updated styling in test image# This is the commit messagematplotlib#4:bug fix inserted
This involved a good bit of debugging of the build process, especiallyfor the bundled FreeType. Eventually removing the debugging flags letit just work.There are still fork failures, but I've done everything I know to do.CYGWIN=detect_bloda may reveal more, but may not.parent48e5934author DWesl <22566757+DWesl@users.noreply.github.com> 1651882104 -0400committer DWesl <22566757+DWesl@users.noreply.github.com> 1670678538 -0500parent48e5934author DWesl <22566757+DWesl@users.noreply.github.com> 1651882104 -0400committer DWesl <22566757+DWesl@users.noreply.github.com> 1670678484 -0500CI: Add a Cygwin run to GHA CI.Let's see if I translated the workflow even close to correctly.CI: Pin Cygwin setuptools<60 and NumPy !=1.21setuptools>60 breaks Pillow install, and may cause problems for NumPy.NumPy 1.21 has intermittent segfaults on GHA runners, so let's just skip that.CI: Pin Cygwin setuptools<60 and avoid problem upgradessetuptools>=60 runs intopython-pillow/Pillow#6216 andpypa/setuptools#3304.NumPy==1.21.* has intermittent segfaults due to SIMD attempts on unaligned memory.kiwisolver, numpy, and pillow have problems installing, so just verify that they are present, don't try to upgrade them.CI: Upgrade Cygwin pipCI: Install g++ and print info on Python.hHopefully one of these will convince NumPy to compile.CI: Install libjpeg-devel for Pillow installLet's see if it keeps setuptools old enough for this to work.CI: BLD: Use system freetype and qhullGiven that I'm checking a build problem at the moment, this should allow that to show up faster.This should probably be reverted before merging.CI: Specify shell for Cygwin pytest step.CI: Rebase Matplotlib DLLs before running pytestTry to avoid "BlockingIOError: Resource Unavailable"with a fork() error on stderr.CI: Compile against bundled freetype.See if this fixes the various test errors.It will take a few tries to get freetype to actually compile, I think.CI: Install make for libfreetype buildLet's see if this lets the build run to completion.BLD: Run autoconf before installing bundled freetypeLet's see if this fixes the install problems.CI: Try to get Cygwin build of FreeType working.It doesn't fail the same way locally.CI: Revert to actually-configured python alternatives.BLD: Fix autoconf call on Cygwin.BLD: Fix directory for Cygwin autoreconf.CI: Fix directory for Cygwin autoconf in FreeType.BLD: Fix autoreconf command line.BLD: Run only autoconf on Cygwin, not autoreconf.libtoolize still fails; let's see if this at least gets through configure now.BLD: Run verbose libtoolize on bundled FreeTypeLet's see if this produces useful information.BLD: Copy the libtool files and ensure write permissionsCopy instead of symlinking, and make sure the current user has write permissions for the target files.BLD: Add print statements to update on Autotools progressLet's see if I this narrows down where the error happens.BLD: Add permissions for everybody to fix libtoolizeIt's the only thing I can think of that would make the copy fail.CI: Try to clean up error reporting.Errors importing matplotlib are distinct from test failures; pip's logs of compile failures have a lot of extra stuff not related to the actual compile failureCI: Skip broken FreeType build on CygwinI'll have to update many tests, but that should be doable.CI: Add FreeType and QHull to Cygwin CII'm going the hard way through the testing process.BLD: Use auto-typed result from dlsymTry to avoid the Cygwin-vs-Linux dlsym signature incompatibility.(Cygwin returns FARPROC aka `long long int (*)()`, Linux returns void *)CI: Add Cygwin dependencies and try to rebase moreLet's hope this sidesteps the BlockingIOErrors in subprocess.runCI: Split Cygwin rebase stepOne step for finding the files.a separate step for rebasing, using only rebase.CI: Only rebase files in /usr/ and /usr/local/GHA gives permissions to write to /usr/local, so pip puts the new files there.CI: Add premissions to the image comparisonsSee if this lets the artifact upload step work.CI: Use the bundled FreeType on Cygwin againCI: Try to change rebase to avoid fork failuresBLD: Fix definition of FT_CONFIG_CONFIG_H on CygwinThe default definition doesn't actually define everything assumed to be defined by that header.It was changed a few versions before, but they seem to have only checked whether it worked a few places.BLD: Add autoconf and libtoolize back inI'd forgotten configure crashed.BLD: Continue on libtoolize failureCI: Try to get more information from makeCI: Uses Cygwin FreeType package again.CI: Try doubled backslashes for result directory.Let's see if this allows upload-artifact to succeed.BUG: Rebase DLLs in ediable installI skipped those earlier, which doesn't do anything useful.CI, BUG: Install git on Cygwin runner.Some of the tests use setuptools_scm, which needs git.CI, BUG: Run actions/checkout before Cygwin installOtherwise git panics about someone else owning the repository midway through cloning.CI, BUG: Mark the repo safe againGit is apparently picky about how I specify Windows paths.CI, DBG: Print Windows permissions for image dirInspired byhttps://social.technet.microsoft.com/wiki/contents/articles/31139.powershell-how-to-get-folder-permissions.aspxApparently Windows "dir" doesn't have an option to output permissions, that's a separate utility.CI, DBG: Print more permissions for result_imagesTry printing permissions of the images that fail to upload. The directory seems to deny only write and delete permissions, which shouldn't cause problems.CI, DBG: Give everyone all permissions to result img dirMaybe this will let upload-artifact succeed.CI: Use dash for /bin/sh on CygwinThis seems to help libtoolize finish without crashing.CI: Try to compile bundled freetype on Cygwin againThis should get farther.CI: FIX: Specify proper shell when setting shell.CI, FIX: Spell shell options correctly to set /bin/shCI, FIX: Use dash to set dash as /bin/sh on CygwinBLD: Specify /bin/dash explicitly for Cygwin FreeType buildTODO: Remember to revert the configure change.CI: Keep bash around when making dash /bin/shCI: Make /bin/sh a symlink to /bin/dashCI: Set Cygwin tempdir to /tmpCI: Explicitly install m4 on Cygwin.CI, DBG: Clarify what /bin/sh is around def change.I want to see how they change before and after I change it from /bin/bash to /bin/dashCI, FIX: Use bash to change /bin/sh to /bin/dashCI, FIX: Clean up syntax to set sh to dash.Also avoid duplicate work for a failure.BLD: Reduce verbosity of FreeType setup on CygwinUse autoreconf instead of autoconf --verboseShould help me figure out where the new failure is.BLD: Stop running autoreconf on CygwinIt doesn't seem to help muchCI, DBG: Only run upload-artifact debuggers if tests ranDon't try to examine images if there hasn't been anything to create them.CI, FIX: Use single quotes for condition.Double quotes cause problemsCI: Allow Cygwin CI to run on patch-2BLD: Revert most changes to setupext.pyStill unconditionally rebuild ./configure on Cygwin, to try to update build system.BLD: Revert the rest of the changes to setupext.pyFreeType seems to build on unmodified matplotlib locally, so this shouldn't be needed.CI: Install matplotlib in Cygwin CIHopefully this pulls in the last dependencies and keeps the FreeType build from failing.CI: Specify MAKEFLAGS, not MAKEhttps://www.gnu.org/software/make/manual/make.html#Options_002fRecursionsuggests specifying MAKEFLAGS to ensue options are passed to make, not MAKE. This might help with the weird "directory not found" errors.CI, BUG: Specify --coverage in CPPFLAGS and LDFLAGSSpecifying in CPPFLAGS only causes link to fail.LDFLAGS=-lgcov should also work, but this should be more general.STY: Remove trainling whitespaceGet pre-commit to stop sending me emails about trailing whitespace.CI,BUG: Make sure coverage library gets linkedThere may be a problem in the configtest procedure.CI: Cut separate build stepIt's failing in the pip install step, and I want to be sure that's not because there's already a build tree.CI: Cygwin: Don't add coverage tracing to matplotlibIt causes pip install to fail.CI: Install importlib_resourcesApparently not listed in the requirements*.txtBUG: Fix spellingCI: Cygwin: Drop LaTeX packagesThe PGF tests mostly fail.CI: Set ffmpeg path so Cygwin tests don't use Windows executableCI: Append to mplrc, don't overwrite.Let's see if this fixes the key lookup error on importCI: Cygwin: Create new mplrc file instead of overwriting oldAppending creates load errors in forked tests; replacing the line should fix that, and creating a new version should fix the remaining problems.CI,FIX: Cygwin: Create mpl config directoriesCI: Cygwin: Don't install WX, do install ipythonWX imports keep failing.One test uses IPython and fails, let's make sure that's not because IPython isn't installed.CI: Cygwin: Uninstall wxPythonIt shouldn't be installed, so this should be fast.CI: Cygwin: Try to get remaining tests working.Rebase executables in /bin as well as those in /usr/binRemove default ACLs on /tmpCI,FIX: Fix syntax and style of previous commit//bin is not POSIX-compliant and doesn't work on Cygwin.Delete trailing whitespace.CI: Cygwin: Set username to root and uid to 0This should let checks for "can I access all files regardless of permissions" work the way Linux expects.CI,FIX: Cygwin: Try to fix sed expression for euid=0Sed expression#2, character 0: error: no previous regex.Not really useful, sed.CI: Cygwin: Stop changing username, just change uidCI: Stop rebasing binaries in /binThey are already covered in /usr/bin, and probably the important information is in the file, not a database somewhere (I mean, it's also in a database, but you can turn that off).CI: Cygwin: Upload code coverage dataCI: Cygwin: Update run condition for upstream repoI changed it so I'd get quicker feedback on tests some time ago and forgot to change it back.Update .github/workflows/tests.ymlCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>Update .github/workflows/tests.ymlCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>CI: Cygwin: Incorporate suggestions from review.CI: Incorporate suggestions from review.CI: Cygwin: Use dash for /bin/sh instead of bash.Faster, and doesn't fail the FreeType build.CI: Test python 3.8 and 3.9 on CygwinCo-authored-by: Thomas A Caswell <tcaswell@gmail.com>CI: Cygwin: Correct matplotlibrc locationApparently it doesn't check ~/.config/matplotlibDOC,CI: Explain why CI runs tests with gid set to 0.The other option is to look into cygutils-extra's cygdrop.I have no idea how to use that, so I'm sticking with this.
feat: add 2 tests based on good/bad plot from upstream issue
This is the commit message#1:> Merge pull request#28293 from QuLogic/py313>> BLD: Enable building Python 3.13 wheels for nightlies(cherry picked from commit725ee99)This is the commit message#2:> Merge pull request#28668 from matplotlib/dependabot/github_actions/actions-167bd8b160>> Bump the actions group with 2 updates(cherry picked from commitfd42e7d)
Remove references to svn, or changed them to refer to the new git repositories.