Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Implement get_cursor_data for QuadMesh.#19908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| data_str = ', '.join('{:0.3g}'.format(item) for item in data | ||
| if isinstance(item, Number)) | ||
| return "[" + data_str + "]" | ||
| if np.ndim(data) == 0 and getattr(self, "colorbar", None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there better criterion than having a colorbar?
You still have a value (~color) in the mesh even if that's not explained via a colorbar. It would be nice if this works for a simpleplt.pcolormesh() call. Also if you plot on multiple Axes with "shared" colors and use only one colorbar as description, AFAIK only one of the Mappables will be associated with the colorbar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The "colorbar-for-value-formatting" discussion is at#12473 (I personally just patch matplotlib locally with that PR...). I think it's orthogonal to the feature here?
The motivation is actually to provide get_cursor_data for hist2d, whichuses a QuadMesh to draw itself (see the test).As it turns out, Collection.contains already contains the relevant codeto find which path contains the mouse event, so just reuse that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While maybe not the 100% solution, this is an improvement for common cases and still has the same behavior othewise (e.g. if there is no colorbar).
The motivation is actually to provide get_cursor_data for hist2d, which
uses a QuadMesh to draw itself (see the test).
As it turns out, Collection.contains already contains the relevant code
to find which path contains the mouse event, so just reuse that.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).