Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Access pdf annotations while inside pikepdf.Pdf context manager.#19824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:pikepdfannots
Mar 30, 2021

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedMar 30, 2021
edited
Loading

Depending on the exact way the pdf file is written, iterating over
Annots can fail after the file has been closed. This is not the case
for matplotlib-generated pdfs, but is the case for mplcairo-generated
ones. As a simple repro of the different behavior between
"in-the-contextmanager" and "out-of-the-contextmanager":

frommatplotlibimportpyplotaspltplt.figtext(.5,.5,"hello, world",url="https://www.google.com")plt.savefig("/tmp/test.pdf",backend="pdf")importpikepdfwithpikepdf.Pdf.open("/tmp/test.pdf")aspdf:page=pdf.pages[0]print(repr(page.Annots))# within contextmanager: okwithpikepdf.Pdf.open("/tmp/test.pdf")aspdf:page=pdf.pages[0]print(repr(page.Annots))# after contextmanager: AttributeError

PR Summary

PR Checklist

  • Has pytest style unit tests (andpytest passes).
  • IsFlake 8 compliant (runflake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • Conforms to Matplotlib style conventions (installflake8-docstrings and runflake8 --docstring-convention=all).
  • New features have an entry indoc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented indoc/api/next_api_changes/ (follow instructions in README.rst there).

Depending on the exact way the pdf file is written, iterating overAnnots can fail after the file has been closed.  This is not the casefor matplotlib-generated pdfs, but is the case for mplcairo-generatedones.  As a simple repro of the different behavior between"in-the-contextmanager" and "out-of-the-contextmanager":```from matplotlib import pyplot as pltplt.figtext(.5, .5, "hello, world", url="https://www.google.com")plt.savefig("/tmp/test.pdf", backend="pdf")import pikepdfwith pikepdf.Pdf.open("/tmp/test.pdf") as pdf:    page = pdf.pages[0]    print(repr(page.Annots)) # within contextmanager: okwith pikepdf.Pdf.open("/tmp/test.pdf") as pdf:    page = pdf.pages[0]print(repr(page.Annots))  # after contextmanager: AttributeError```
@QuLogicQuLogic merged commitbba76b8 intomatplotlib:masterMar 30, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 30, 2021
@anntzeranntzer deleted the pikepdfannots branchMarch 30, 2021 21:39
QuLogic added a commit that referenced this pull requestMar 31, 2021
…824-on-v3.4.xBackport PR#19824 on branch v3.4.x (Access pdf annotations while inside pikepdf.Pdf context manager.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.1
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp